Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-111696: type(str) returns the fully qualified name#112129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
vstinner wants to merge2 commits intopython:mainfromvstinner:type_str

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedNov 15, 2023•
edited by github-actionsbot
Loading

  • Update modules:

    • enum
    • functools
    • optparse
    • pdb
    • xmlrcp.server

  • Update tests:

    • test_dataclasses
    • test_descrtut
    • test_cmd_line_script

📚 Documentation preview 📚:https://cpython-previews--112129.org.readthedocs.build/

* Update modules:  * enum  * functools  * optparse  * pdb  * xmlrcp.server* Update tests:  * test_dataclasses  * test_descrtut  * test_cmd_line_script
@vstinner
Copy link
MemberAuthor

I failed to fixtest_basics() of test_enum which fails. But well, I don't think that this backward incompatible change is a good idea, so I don't plan to decidate too much time to it :-)

@vstinner
Copy link
MemberAuthor

I created this PR to show that changingstr(type) is a bad idea: it breaks the backward compatibility and it requires to change too much code which currently works fine. I close this PR.

gpshead reacted with thumbs up emojigpshead reacted with heart emoji

@vstinnervstinner deleted the type_str branchNovember 28, 2023 15:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman will be requested when the pull request is marked ready for reviewethanfurman is a code owner

@terryjreedyterryjreedyAwaiting requested review from terryjreedyterryjreedy will be requested when the pull request is marked ready for reviewterryjreedy is a code owner

@ericvsmithericvsmithAwaiting requested review from ericvsmithericvsmith will be requested when the pull request is marked ready for reviewericvsmith is a code owner

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger will be requested when the pull request is marked ready for reviewrhettinger is a code owner

@gaogaotiantiangaogaotiantianAwaiting requested review from gaogaotiantiangaogaotiantian will be requested when the pull request is marked ready for reviewgaogaotiantian is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon will be requested when the pull request is marked ready for reviewmarkshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp