Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
[3.12] gh-111942: Fix SystemError in the TextIOWrapper constructor (#112061)#112089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…thon#112061)In non-debug more the check for the "errors" argument is skipped,and then PyUnicode_AsUTF8() can fail, but its result was not checked.Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit9302f05)
This was referencedNov 14, 2023
This was referencedNov 14, 2023
"Check if generated files are up to date" job failed because of quay.io server issue:#112088 |
serhiy-storchaka approved these changesNov 15, 2023
serhiy-storchaka added a commit to miss-islington/cpython that referenced this pull requestNov 15, 2023
…tor (pythonGH-112061) (pythonGH-112089)In non-debug more the check for the "errors" argument is skipped,and then PyUnicode_AsUTF8() can fail, but its result was not checked.Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit9302f05)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
In non-debug more the check for the "errors" argument is skipped, and then PyUnicode_AsUTF8() can fail, but its result was not checked.
Co-authored-by: Victor Stinnervstinner@python.org
(cherry picked from commit9302f05)