Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-111942: Fix SystemError in the TextIOWrapper constructor#112061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
In non-debug more the check for the "errors" argument is skipped,and then PyUnicode_AsUTF8() can fail, but its result was not checked.
bd438e2 to0a85bf3CompareUh oh!
There was an error while loading.Please reload this page.
The previous change broke the Python workflow:#111976 (comment) This change should fix it. |
Thanks@serhiy-storchaka for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry,@serhiy-storchaka and@vstinner, I could not cleanly backport this to |
…thonGH-112061)In non-debug more the check for the "errors" argument is skipped,and then PyUnicode_AsUTF8() can fail, but its result was not checked.(cherry picked from commit9302f05)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Victor Stinner <vstinner@python.org>
GH-112085 is a backport of this pull request to the3.12 branch. |
I'm still seeing the |
Nm, it looks like it's passing now on a different buildbot (not sure if the "changes" tab was somehow stale on the buildbot master and it misattributed the contributing PRs). |
Time to time, I check the [Build Properties] tab to get the Git commit number. Sometimes, tracking buildbots can be confusing. |
GH-112089 is a backport of this pull request to the3.12 branch. |
…thon#112061)In non-debug more the check for the "errors" argument is skipped,and then PyUnicode_AsUTF8() can fail, but its result was not checked.Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit9302f05)
…thon#112061)In non-debug more the check for the "errors" argument is skipped,and then PyUnicode_AsUTF8() can fail, but its result was not checked.Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit9302f05)
I planned to do this in the following PR. This PR cannot be automatically backported with these changes. Do you mind to create backports manually? |
I wrote PR#112089 for Python 3.12 using Then Python 3.11 can get the first change directly with the second fix (merged as a single PR). |
…tor (pythonGH-112061) (pythonGH-112089)In non-debug more the check for the "errors" argument is skipped,and then PyUnicode_AsUTF8() can fail, but its result was not checked.Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit9302f05)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…thon#112061)In non-debug more the check for the "errors" argument is skipped,and then PyUnicode_AsUTF8() can fail, but its result was not checked.Co-authored-by: Victor Stinner <vstinner@python.org>
…thon#112061)In non-debug more the check for the "errors" argument is skipped,and then PyUnicode_AsUTF8() can fail, but its result was not checked.Co-authored-by: Victor Stinner <vstinner@python.org>
Uh oh!
There was an error while loading.Please reload this page.
In non-debug more the check for the "errors" argument is skipped, and then PyUnicode_AsUTF8() can fail, but its result was not checked.