NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.4k

[3.11] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976)#112059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 2 commits intopython:3.11frommiss-islington:backport-ee06fff-3.11

Nov 15, 2023

Merged

[3.11] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976)#112059

serhiy-storchaka merged 2 commits intopython:3.11frommiss-islington:backport-ee06fff-3.11

Nov 15, 2023

Conversation

Copy link

Contributor

miss-islington commentedNov 14, 2023•
edited by bedevere-appbot
Loading

Fix crash when encoding is not string or None.
Fix crash when both line_buffering and write_through raise exception
when converted ti int.
Add a number of tests for constructor and reconfigure() method
with invalid arguments.
(cherry picked from commitee06fff)

Co-authored-by: Serhiy Storchakastorchaka@gmail.com

Issue:TextIOWrapper.reconfigure() crashes if encoding is not string or None #111942

pythongh-111942: Fix crashes in TextIOWrapper.reconfigure() (pythonGH…

c4fc137

…-111976)* Fix crash when encoding is not string or None.* Fix crash when both line_buffering and write_through raise exception  when converted ti int.* Add a number of tests for constructor and reconfigure() method  with invalid arguments.(cherry picked from commitee06fff)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-appbot added the awaiting review label

Nov 14, 2023

This was referencedNov 14, 2023

TextIOWrapper.reconfigure() crashes if encoding is not string or None#111942

Closed

gh-111942: Fix crashes in TextIOWrapper.reconfigure()#111976

Merged

serhiy-storchakaenabled auto-merge (squash)

November 14, 2023 15:39

Copy link

Member

vstinner commentedNov 14, 2023

test_io failed on Address Sanitizer job:

ERROR: test_constructor (test.test_io.CTextIOWrapperTest.test_constructor)----------------------------------------------------------------------UnicodeEncodeError: 'utf-8' codec can't encode character '\udcfe' in position 0: surrogates not allowedThe above exception was the direct cause of the following exception:Traceback (most recent call last):  File "/home/runner/work/cpython/cpython/Lib/test/test_io.py", line 2631, in test_constructor    t.__init__(b, encoding="utf-8", errors='\udcfe')SystemError: <method 'readable' of '_io.BytesIO' objects> returned a result with an exception set

This PR should be backport to 3.11 with its fix. I will wait until#112089 is merged into 3.12.

[3.12]pythongh-111942: Fix SystemError in the TextIOWrapper construc…

52cafc8

…tor (pythonGH-112061) (pythonGH-112089)In non-debug more the check for the "errors" argument is skipped,and then PyUnicode_AsUTF8() can fail, but its result was not checked.Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit9302f05)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka merged commite2421a3 intopython:3.11

Nov 15, 2023

bedevere-appbot removed the awaiting review label

Nov 15, 2023