Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-111906: Removeunused function warnings during mimalloc build on FREEBSD#111907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 3 commits intopython:mainfromfurkanonder:issue-111906
Nov 14, 2023

Conversation

furkanonder
Copy link
Contributor

@furkanonderfurkanonder commentedNov 9, 2023•
edited by bedevere-appbot
Loading

@erlend-aasland
Copy link
Contributor

cc.@vstinner, who have been interested in FreeBSD builds lately (IIRC).

@vstinner
Copy link
Member

!buildbot FreeBSD

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@vstinner for commit4717fb0 🤖

The command will test the builders whose names match following regular expression:FreeBSD

The builders matched are:

  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD PR

@vstinner
Copy link
Member

In arecent FreeBSD 14 buildbot build, I see the following compiler warnings:

Objects/mimalloc/prim/unix/prim.c:66:12: warning: unused function 'mi_prim_open' [-Wunused-function]Objects/mimalloc/prim/unix/prim.c:69:16: warning: unused function 'mi_prim_read' [-Wunused-function]Objects/mimalloc/prim/unix/prim.c:72:12: warning: unused function 'mi_prim_close' [-Wunused-function]Objects/mimalloc/prim/unix/prim.c:75:12: warning: unused function 'mi_prim_access' [-Wunused-function]

I scheduled FreeBSD builds to see if the code still builds and if warnings are done.

@vstinner
Copy link
Member

With this change, build succeeded on the 3 FreeBSD buildbot jobs:

Moreover, I don't see compiler warnings anymore aboutObjects/mimalloc/. So the change works as expected.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks.

@vstinner
Copy link
Member

@DinoV: how can you make these changes upstream? I would prefer to not lose them at the next mimalloc sync.

erlend-aasland reacted with thumbs up emoji

@vstinnervstinner merged commit0ff6368 intopython:mainNov 14, 2023
@vstinner
Copy link
Member

Merged. Thanks@furkanonder for your fix.

@furkanonder
Copy link
ContributorAuthor

Merged. Thanks@furkanonder for your fix.

You are welcome.

aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…n#111907)Fix `unused function` warnings during mimalloc build on FreeBSD.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…n#111907)Fix `unused function` warnings during mimalloc build on FreeBSD.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@furkanonder@erlend-aasland@vstinner@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp