Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-111460: restore ncurses widechar support on macOS#111878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
corona10 merged 1 commit intopython:mainfromsorcio:macos-restore-ncursesw
Nov 13, 2023

Conversation

sorcio
Copy link
Contributor

@sorciosorcio commentedNov 9, 2023•
edited by bedevere-appbot
Loading

Ncurses wide character support on macOS was broken as an unintended consequence of#94452. It is now built as intended.

@erlend-aasland
Copy link
Contributor

Do you have the bandwidth to review this,@corona10?

@corona10
Copy link
Member

This weekend I will try :)

@corona10corona10 added the needs backport to 3.12only security fixes labelNov 13, 2023
Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm!

I checked that what kinds of value $have_curses can have from source codes

cpython/configure.ac

Lines 6255 to 6271 ine1a1e32

AS_VAR_IF([ac_cv_header_ncurses_h],[yes],[
if test "$ac_sys_system" != "Darwin"; then
dnl On macOS, there is no separate /usr/lib/libncursesw nor libpanelw.
PKG_CHECK_MODULES([CURSES],[ncursesw],[
AC_DEFINE([HAVE_NCURSESW],[1])
have_curses=ncursesw
],[
WITH_SAVE_ENV([
AC_CHECK_LIB([ncursesw],[initscr],[
AC_DEFINE([HAVE_NCURSESW],[1])
have_curses=ncursesw
CURSES_CFLAGS=${CURSES_CFLAGS-""}
CURSES_LIBS=${CURSES_LIBS-"-lncursesw"}
])
])
])
fi

Thanks for catching this.
This PR should be backported

@corona10corona10 merged commitd2f305d intopython:mainNov 13, 2023
@miss-islington-app
Copy link

Thanks@sorcio for the PR, and@corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 13, 2023
…111878)(cherry picked from commitd2f305d)Co-authored-by: Davide Rizzo <sorcio@gmail.com>
@bedevere-app
Copy link

GH-112034 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelNov 13, 2023
corona10 pushed a commit that referenced this pull requestNov 14, 2023
… (gh-112034)gh-111460: Restore ncurses widechar support on macOS (GH-111878)(cherry picked from commitd2f305d)Co-authored-by: Davide Rizzo <sorcio@gmail.com>
@sorciosorcio deleted the macos-restore-ncursesw branchNovember 14, 2023 16:55
@Turakar
Copy link

Might it be that a similar fix needs to be applied to the following line:

if test "$ac_sys_system" != "Darwin"; then

It seems to me like this check is equally broken.

@erlend-aasland
Copy link
Contributor

Might it be that a similar fix needs to be applied to the following line:

if test "$ac_sys_system" != "Darwin"; then

It seems to me like this check is equally broken.

Please open a new issue for this.

aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@corona10corona10corona10 approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@sorcio@erlend-aasland@corona10@Turakar
[8]ページ先頭
©2009-2025 Movatter.jp