Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

pythongh-111835: Add seekable method to mmap.mmap#111865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

technillogue
Copy link
Contributor

@technilloguetechnillogue commentedNov 8, 2023•
edited
Loading

@ghost
Copy link

ghost commentedNov 8, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@technilloguetechnillogue changed the title,pythongh-111835: Add seekable method to mmap.mmappythongh-111835: Add seekable method to mmap.mmapNov 8, 2023
Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

FYI, I already opened the PR 7 hours ago.
#111852

And please read the comment about seek() method at#111852 (comment)

@@ -737,6 +737,14 @@ mmap_seek_method(mmap_object *self, PyObject *args)
return NULL;
}


static PyObject *
mmap_seekable_method(mmap_object *self, PyObject *unused)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
mmap_seekable_method(mmap_object*self,PyObject*unused)
mmap_seekable_method(mmap_object*self,PyObject*Py_UNUSED(ignored))

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10
Copy link
Member

#111852 is merged!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@corona10corona10corona10 requested changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@technillogue@corona10
[8]ページ先頭
©2009-2025 Movatter.jp