Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-81925: Implement the native thread ids for KFreeBSD#111761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pitrou merged 3 commits intopython:mainfromsthibaul:native_id
Nov 9, 2023

Conversation

@sthibaul
Copy link
Contributor

@sthibaulsthibaul commentedNov 5, 2023
edited by bedevere-appbot
Loading

@pitroupitrou requested a review fromgpsheadNovember 9, 2023 12:12
@sthibaulsthibaulforce-pushed thenative_id branch 2 times, most recently from39c4998 tocea0d45CompareNovember 9, 2023 14:13
@sthibaulsthibaul changed the titlegh-81925: Implement the native thread ids for the Hurd and KFreeBSDgh-81925: Implement the native thread ids for KFreeBSDNov 9, 2023
@pitrou
Copy link
Member

Thanks for the update. Can you also update the docshere andhere? The updated markup could be something like:

   ..availability::Windows, FreeBSD, Linux, macOS, OpenBSD, NetBSD, AIX, DragonFlyBSD, GNU/kFreeBSD.   ..versionadded::3.8   ..versionchanged::3.13      Added support for GNU/kFreeBSD.

@sthibaul
Copy link
ContributorAuthor

Thanks for the update. Can you also update the docshere andhere? The updated markup could be something like:

Done so!

"AIX","Android","BSD","DragonFlyBSD","Emscripten","FreeBSD",
"Linux","NetBSD","OpenBSD","POSIX","Solaris","Unix","VxWorks",
"WASI","Windows","macOS",
"GNU/kFreeBSD","Linux","NetBSD","OpenBSD","POSIX","Solaris",
Copy link
Member

@pitroupitrouNov 9, 2023
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@encukou Does this seem ok to you?

@pitroupitrou added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 9, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@pitrou for commitb74f76e 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 9, 2023
@encukou
Copy link
Member

The code change looks OK to me, but I would not change the docs -- the mentions suggest that we'll keepGNU/kFreeBSD support working, which we currently can't promise as we (AFAIK) don't have a stable buildbot for it.

@encukou
Copy link
Member

encukou commentedNov 9, 2023
edited
Loading

(Sorry,@sthibaul, for maintainers disagreeing with each other with you caught in the cross-fire. Don't change stuff until we agree what to do.)

@pitrou
Copy link
Member

pitrou commentedNov 9, 2023
edited
Loading

The code change looks OK to me, but I would not change the docs -- the mentions suggest that we'll keepGNU/kFreeBSD support working, which we currently can't promise as we (AFAIK) don't have a stable buildbot for it.

We're not promising anything even on other platforms, AFAICT. The tests fornative_id /get_native_id don't check for specific platforms, so the feature could quietly be disabled on supposedly-supported platforms.

@pitrou
Copy link
Member

The buildbot failures are unrelated, so I'll merge.

@pitroupitrou merged commit0802fd6 intopython:mainNov 9, 2023
@malemburg
Copy link
Member

Just saw this on the checkins ML and curious: why are we adding support for anofficially terminated variant of Debian ?

@pitrou
Copy link
Member

Oh, I was not aware of that. Given that support here requires minimal code and doesn't affect the rest of the (non-kFreeBSD-specific) code, I thought the PR was fine.

@sthibaul Is kFreeBSD actually unmaintained, or is it just maintained outside of Debian?

Also cc@gpshead for opinions.

@sthibaul
Copy link
ContributorAuthor

GNU/kFreeBSD is not only about Debian. Python already has various places where the GNU/kFreeBSD__FreeBSD_kernel__ macro appears, so this is not a new thing for Python, just a missing bit here.
The support of GNU/kFreeBSD was indeed recently dropped in the Debian distribution, I haven't checked if it exists in other distributions, Arch for instance, probably. It doesn't hurt much to keep the macros in place (I have to say that python isvery portable with very few such #ifdefs)

@malemburg
Copy link
Member

So this is more about supporting FreeBSD, than specifically GNU/kFreeBSD ? That would make sense.

@sthibaul
Copy link
ContributorAuthor

Yes, it's about supporting the FreeBSD kernel without the usual BSD userland. It's not actually specific to being GNU/kFreeBSD, it could be whatever/kFreeBSD

@gpshead
Copy link
Member

The key part of this PR is just adding|| defined(__FreeBSD_kernel__) to the C preprocessor checks. That's fine even if nobody can build or maintain anything on such an esoteric system.

I think the docs mentioning the never going to be used by any non-hobbyistGNU/kFreeBSD is the wrong terminology: just leave that as a more generic "FreeBSD kernel" statement (not even expecting anyone to understand the kFreeBSD term). If I were authoring this PR I'd have just updated "FreeBSD" in the existing list to "FreeBSD kernel" in the docs as that itself implies actual FreeBSD as far as most any reader is concerned.

aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
---------Co-authored-by: Antoine Pitrou <antoine@python.org>
@hugovk
Copy link
Member

Triage: I've closed the issue for this PR. Please re-open or create a new issue if needed.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
---------Co-authored-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

@gpsheadgpsheadAwaiting requested review from gpshead

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sthibaul@pitrou@bedevere-bot@encukou@malemburg@gpshead@hugovk

[8]ページ先頭

©2009-2025 Movatter.jp