Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
GH-109369: Exit tier 2 if executor is invalid#111657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
So, on the JIT branch, we don't actually keep the executor handy when executing instructions (only when entering/exiting traces). I'm guessing we'll need it a lot more in the future once we start doing stitching and such, but I wonder: can we just stick it on the Not a big deal though, and can be deferred to a later date. Just something to ponder, or to do if it's easy now. |
brandtbucher commentedNov 8, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Idea: put the executor's address in |
Ah, never mind, the JIT can burn in the executor. I withdraw my comments. :) |
Uh oh!
There was an error while loading.Please reload this page.
FixesGH-109369.
Adds a
_CHECK_VALIDITYuop which is inserted after any escaping operations.Ensures that uop traces will be exited promptly if the code is instrumented.