Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-109369: Exit tier 2 if executor is invalid#111657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
markshannon merged 11 commits intopython:mainfromfaster-cpython:exit-if-invalid
Nov 9, 2023

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commentedNov 2, 2023
edited
Loading

FixesGH-109369.
Adds a_CHECK_VALIDITY uop which is inserted after any escaping operations.
Ensures that uop traces will be exited promptly if the code is instrumented.

@markshannonmarkshannon marked this pull request as ready for reviewNovember 6, 2023 14:36
markshannonand others added2 commitsNovember 8, 2023 12:28
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@brandtbucher
Copy link
Member

So, on the JIT branch, we don't actually keep the executor handy when executing instructions (only when entering/exiting traces). I'm guessing we'll need it a lot more in the future once we start doing stitching and such, but I wonder: can we just stick it on thetstate or theframe? It feels a bit painful to dedicate a register to this thing, especially since it'll be hardly used in optimized traces (I think).

Not a big deal though, and can be deferred to a later date. Just something to ponder, or to do if it's easy now.

@brandtbucher
Copy link
Member

brandtbucher commentedNov 8, 2023
edited
Loading

Idea: put the executor's address in_CHECK_VALIDITY'soperand? Then the JIT would require no modifications to support this change.

@brandtbucher
Copy link
Member

Ah, never mind, the JIT can burn in the executor. I withdraw my comments. :)

@markshannonmarkshannon merged commit25c4956 intopython:mainNov 9, 2023
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
@markshannonmarkshannon deleted the exit-if-invalid branchAugust 6, 2024 10:18
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Executors might ignore instrumentation.

3 participants

@markshannon@brandtbucher@iritkatriel

[8]ページ先頭

©2009-2025 Movatter.jp