Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-111354: Simplify _PyGen_yf by moving some of its work to the compiler and frame state#111648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 2 commits intopython:mainfromiritkatriel:gen_yf
Nov 3, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedNov 2, 2023•
edited by github-actionsbot
Loading

This splits the SUSPENDED frame state into SUSPENDED and SUSPENDED_YIELD_FROM, adds an oparg to YIELD_VALUE to indicate whether it's in a yield-from or await (so it can set the state correctly). With this,_PyGen_yf has a lot less work to do.

📚 Documentation preview 📚:https://cpython-previews--111648.org.readthedocs.build/

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like to avoid the extra branch inYIELD_VALUE.
Other than that, looks good.

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@iritkatriel
Copy link
MemberAuthor

iritkatriel commentedNov 2, 2023•
edited
Loading

I have made the requested changes; please review again.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good.

@iritkatrieliritkatriel merged commitd49aba5 intopython:mainNov 3, 2023
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonmarkshannon approved these changes

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@iritkatriel@markshannon
[8]ページ先頭
©2009-2025 Movatter.jp