Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-108082: Remove _PyErr_WriteUnraisableMsg()#111643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 2 commits intopython:mainfromserhiy-storchaka:capi-remove-_PyErr_WriteUnraisableMsgNov 3, 2023
Merged
gh-108082: Remove _PyErr_WriteUnraisableMsg()#111643
serhiy-storchaka merged 2 commits intopython:mainfromserhiy-storchaka:capi-remove-_PyErr_WriteUnraisableMsgNov 3, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Replace the remaining calls with PyErr_FormatUnraisable().
vstinner approved these changesNov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. I only looked at C changes, I didn't review the tests changes.
FullteaR pushed a commit to FullteaR/cpython that referenced this pull requestNov 3, 2023
Replace the remaining calls with PyErr_FormatUnraisable().
vstinner added a commit to vstinner/cffi that referenced this pull requestNov 15, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.The private _PyErr_WriteUnraisableMsg() function was removed inPython 3.13:python/cpython#111643
vstinner added a commit to vstinner/cffi that referenced this pull requestNov 15, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.The private _PyErr_WriteUnraisableMsg() function was removed inPython 3.13:python/cpython#111643
cffi uses the private _PyErr_WriteUnraisableMsg() removed in Python 3.13. I wrotepython-cffi/cffi#34 to update the code to the public PyErr_FormatUnraisable() function. |
vstinner added a commit to vstinner/cffi that referenced this pull requestNov 15, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.The private _PyErr_WriteUnraisableMsg() function was removed inPython 3.13:python/cpython#111643
arigo pushed a commit to python-cffi/cffi that referenced this pull requestNov 16, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.The private _PyErr_WriteUnraisableMsg() function was removed inPython 3.13:python/cpython#111643
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Replace the remaining calls with PyErr_FormatUnraisable().
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Replace the remaining calls with PyErr_FormatUnraisable().
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Replace the remaining calls with PyErr_FormatUnraisable().