Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-111495: add stub files for C API test modules#111586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

skirpichev
Copy link
Contributor

@skirpichevskirpichev commentedNov 1, 2023•
edited by bedevere-appbot
Loading

This is to reduce merge conflicts (Modules/Setup.stdlib.in) for subsequent pull requests for the issue.

This is to reduce merge conflicts (Modules/Setup.stdlib.in) forsubsequent pull requests for the issue.
@bedevere-appbedevere-appbot mentioned this pull requestNov 1, 2023
10 tasks
@skirpichev
Copy link
ContributorAuthor

So far there is only files from#111496,#111562 and#109647. More is coming.

CC@serhiy-storchaka

@skirpichevskirpichev marked this pull request as ready for reviewNovember 1, 2023 02:39
@skirpichevskirpichev requested a review froma team as acode ownerNovember 1, 2023 02:39
@skirpichev
Copy link
ContributorAuthor

Ok, all test modules for#111495 were added.@serhiy-storchaka, this is ready for review.

BTW, perhaps this should be labeled "tests" automatically?

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I prefer to remove parameter names in declarations, but LGTM.

@serhiy-storchakaserhiy-storchaka added testsTests in the Lib/test dir needs backport to 3.12only security fixes skip news labelsNov 1, 2023
@serhiy-storchaka
Copy link
Member

It could be an opportunity to re-order all lists in alphabetic order, but it would make more difficult to see what items were added.

@serhiy-storchakaserhiy-storchaka merged commit33ed5fa intopython:mainNov 1, 2023
@miss-islington-app
Copy link

Thanks@skirpichev for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@skirpichev and@serhiy-storchaka, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 33ed5fa69dbe25d64a910c450be527f4db9dc5dd 3.12

@serhiy-storchaka
Copy link
Member

I guess some changes were not backported to 3.12.@skirpichev could you please manually create a backport?

@skirpichev
Copy link
ContributorAuthor

skirpichev commentedNov 1, 2023 via email

On Tue, Oct 31, 2023 at 10:46:46PM -0700, Serhiy Storchaka wrote: I guess some changes were not backported to 3.12. ***@***.*** could you please manually create a backport?
Sure, I'll try.

@skirpichevskirpichev deleted the add-stubs-for-capi-tests branchNovember 1, 2023 06:03
skirpichev added a commit to skirpichev/cpython that referenced this pull requestNov 1, 2023
…GH-111586)This is to reduce merge conflicts (Modules/Setup.stdlib.in) forsubsequent pull requests for the issue.(cherry picked from commit33ed5fa)Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

GH-111592 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelNov 1, 2023
serhiy-storchaka pushed a commit that referenced this pull requestNov 1, 2023
…H-111592)This is to reduce merge conflicts (Modules/Setup.stdlib.in) forsubsequent pull requests for the issue.(cherry picked from commit33ed5fa)
FullteaR pushed a commit to FullteaR/cpython that referenced this pull requestNov 3, 2023
This is to reduce merge conflicts (Modules/Setup.stdlib.in) forsubsequent pull requests for the issue.
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
This is to reduce merge conflicts (Modules/Setup.stdlib.in) forsubsequent pull requests for the issue.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
This is to reduce merge conflicts (Modules/Setup.stdlib.in) forsubsequent pull requests for the issue.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@skirpichev@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp