Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-76785: Add an Internal ExceptionSnapshot Type#111572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
ericsnowcurrently wants to merge7 commits intopython:mainfromericsnowcurrently:crossinterp-utils-exc-snapshot
Closed
gh-76785: Add an Internal ExceptionSnapshot Type#111572
ericsnowcurrently wants to merge7 commits intopython:mainfromericsnowcurrently:crossinterp-utils-exc-snapshot
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
19bd5fc tob8ea359Compare| exctype = PyExc_RuntimeError; | ||
| } | ||
| _Py_excinfo_Apply(&self->info, exctype); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Where is this function defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In Python/errors.c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah I see, I needed to refresh my branch.
This looks like a DIY serialisation of exceptions. Does it work for all exception types? What if the args to the exception constructor are not just the msg string?
b8ea359 to29affcdCompareericsnowcurrently added a commit that referenced this pull requestNov 6, 2023
…1715)I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) ingh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (seegh-111572/gh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are.(FWIW, I may combine that withgh-111572, which I may, in turn, combine withgh-111573. We'll see.)
…l C-API (pythongh-111715)"This reverts commitd4426e8.
29affcd tob9f7974Comparehugovk pushed a commit to hugovk/cpython that referenced this pull requestNov 8, 2023
…ythongh-111715)I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) inpythongh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (seepythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are.(FWIW, I may combine that withpythongh-111572, which I may, in turn, combine withpythongh-111573. We'll see.)
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…ythongh-111715)I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) inpythongh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (seepythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are.(FWIW, I may combine that withpythongh-111572, which I may, in turn, combine withpythongh-111573. We'll see.)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…ythongh-111715)I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) inpythongh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (seepythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are.(FWIW, I may combine that withpythongh-111572, which I may, in turn, combine withpythongh-111573. We'll see.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This will be used by _xxsubinterpretersmodule.c in a follow-up PR, though it should have utility on its own.