Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-110812: Isolating Extension Modules HOWTO: List GC-related gotchas#111504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 6 commits intopython:mainfromencukou:howto-clarifications
Nov 16, 2023

Conversation

encukou
Copy link
Member

@encukouencukou commentedOct 30, 2023•
edited by github-actionsbot
Loading

Here's more text on how to avoid the GC-related gotchas when defining heap types.

(See also:capi-workgroup/problems#49)

📚 Documentation preview 📚:https://cpython-previews--111504.org.readthedocs.build/

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for following up on this,@encukou! I think this is a nice improvement, though I'll rely on@1st1 to say for sure. 😄 I've left a few small comments.

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@ericsnowcurrently
Copy link
Member

@pablogsal, do you think this change would have helped Yury get things right without your help?

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@pablogsal
Copy link
Member

@pablogsal, do you think this change would have helped Yury get things right without your help?

Yup! This is indeed fantastic. Thank you@ericsnowcurrently and@encukou

encukou reacted with heart emoji

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@encukouencukou merged commit985679f intopython:mainNov 16, 2023
@encukouencukou deleted the howto-clarifications branchNovember 16, 2023 11:05
@encukouencukou added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsNov 16, 2023
@miss-islington-app
Copy link

Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 16, 2023
…otchas (pythonGH-111504)(cherry picked from commit985679f)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 16, 2023
…otchas (pythonGH-111504)(cherry picked from commit985679f)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@bedevere-app
Copy link

GH-112147 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelNov 16, 2023
@bedevere-app
Copy link

GH-112148 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelNov 16, 2023
encukou added a commit that referenced this pull requestNov 16, 2023
…gotchas (GH-111504) (GH-112147)gh-110812: Isolating Extension Modules HOWTO: List GC-related gotchas (GH-111504)(cherry picked from commit985679f)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
encukou added a commit that referenced this pull requestNov 16, 2023
…gotchas (GH-111504) (GH-112148)gh-110812: Isolating Extension Modules HOWTO: List GC-related gotchas (GH-111504)(cherry picked from commit985679f)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…otchas (pythonGH-111504)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…otchas (pythonGH-111504)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@1st11st1Awaiting requested review from 1st1

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@encukou@ericsnowcurrently@pablogsal@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp