Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-76785: Move the Cross-Interpreter Code to Its Own File#111502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-76785: Move the Cross-Interpreter Code to Its Own File#111502
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
| }; | ||
| PyAPI_FUNC(_PyCrossInterpreterData *) _PyCrossInterpreterData_New(void); | ||
| PyAPI_FUNC(void) _PyCrossInterpreterData_Free(_PyCrossInterpreterData *data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you don't need one of these functions in shared libraries (stdlib extensions), you can replace PyAPI_FUNC() with extern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
They're basically all used in _xxsubinterpretersmodule.c and _xxinterpchannelsmodule.c.
…ongh-111502)This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c. This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h).@vstinner did this previously and I undid it. Now I'm re-doing it. :/
…ongh-111502)This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c. This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h).@vstinner did this previously and I undid it. Now I'm re-doing it. :/
…ongh-111502)This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c. This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h).@vstinner did this previously and I undid it. Now I'm re-doing it. :/
Uh oh!
There was an error while loading.Please reload this page.
This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c.
This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h).@vstinner did this previously and I undid it. Now I'm re-doing it. :/
(This PR essentially only moves existing code between files.)