Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-111246: Remove listening Unix socket on close#111483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedOct 30, 2023 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Try to clean up the socket file we create so we don't add unused noiseto the file system.
We only want to clean up *our* socket, so try to determine if we stillown this address or if something else has replaced it.
Allow the implicit cleanup to be disabled in case there are some oddcorner cases where this causes issues.
Once review has started (now) please don't force-push -- just add additional commits, otherwise review will be more work. We'll squash merge the final approved PR anyway. Also, merging main is usually not needed (GitHub is a bit pushy around that). |
Ah, sorry. I'm used to the Linux kernel model where you churn the patch set until you have a history everyone is happy with. :) I guess that means my careful splitting into distinct features wasn't necessary either. :) FYI, the CLA is in progress via the slower organization route. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LG, two nits. Thanks for helping out!
Uh oh!
There was an error while loading.Please reload this page.
| @@ -147,6 +149,74 @@ async def serve(*args): | |||
| await task2 | |||
| class UnixServerCleanupTests(unittest.IsolatedAsyncioTestCase): | |||
| @socket_helper.skip_unless_bind_unix_socket | |||
| async def test_unix_server_addr_cleanup(self): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would you mind adding one-line comments to the new tests explaining what each test checks? They look so similar I first thought you had accidentally copied the test a few times. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure. A commit with comments have been pushed.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
@CendioOssman Could you sign the CLA please so we can merge? |
It was signed last Tuesday, so it should hopefully be in someone's queue. I got a confirmation from Adobe at least. |
Okay, I'll wait a bit for our side to update the database then. |
@CendioOssman, in the case of corporate CLAs we still need you to click through the personal CLA signing route to mark your email as green. We don't use blanket email domain approvals. |
Ah. The link said I should use the manual form "instead", so I never proceeded with the GitHub form. I've clicked through the personal approval as well now. |
Try to clean up the socket file we create so we don't add unused noise to the file system.
This is derived frompython/cpython#111483 but available onall Python versions with uvloop, only that it's only enabledby default for Python 3.13 and above to be consistent withCPython behavior.
Try to clean up the socket file we create so we don't add unused noise to the file system.
This is derived frompython/cpython#111483 but available onall Python versions with uvloop, only that it's only enabledby default for Python 3.13 and above to be consistent withCPython behavior.* Also add Python 3.13 to CI (#610)* Enable CI in debug mode* Fix CI to include [dev]---------Co-authored-by: Fantix King <fantix.king@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Relieve developers from the burden of manually cleaning up their Unix sockets by having asyncio take care of that internally.
Fixes#111246.
📚 Documentation preview 📚:https://cpython-previews--111483.org.readthedocs.build/