NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-108082: C API: Add tests for PyErr_WriteUnraisable()#111455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 3 commits intopython:mainfromserhiy-storchaka:test-capi-PyErr_WriteUnraisable

Oct 30, 2023

Merged

gh-108082: C API: Add tests for PyErr_WriteUnraisable()#111455

serhiy-storchaka merged 3 commits intopython:mainfromserhiy-storchaka:test-capi-PyErr_WriteUnraisable

Oct 30, 2023

Conversation

Copy link

Member

serhiy-storchaka commentedOct 29, 2023•
edited by github-actionsbot
Loading

Also document the behavior when called with NULL.

Issue:[C API] Enhance PyErr_WriteUnraisable() API to pass an error message #108082

📚 Documentation preview 📚:https://cpython-previews--111455.org.readthedocs.build/

pythongh-108082: C API: Add tests for PyErr_WriteUnraisable()

93da12c

Also document the behavior when called with NULL.

serhiy-storchaka requested a review fromvstinner

October 29, 2023 11:29

bedevere-appbot mentioned this pull request

Oct 29, 2023

[C API] Enhance PyErr_WriteUnraisable() API to pass an error message#108082

Closed

bedevere-appbot added the awaiting core review label

Oct 29, 2023

serhiy-storchaka added tests

Tests in the Lib/test dir

docs

Documentation in the Doc dir

skip news needs backport to 3.12only security fixes labels

Oct 29, 2023

serhiy-storchaka mentioned this pull request

Oct 29, 2023

gh-108082: Add PyErr_FormatUnraisable() function#111086

Merged

Remove ".. versionchanged:: 3.2" as insignificant.

1ff4c08

serhiy-storchaka commented

Oct 29, 2023

View reviewed changes

Doc/c-api/exceptions.rst

Comment on lines +98 to +99

		.. versionchanged:: 3.4
		Print a traceback. Print only traceback if obj is ``NULL``.

Copy link

MemberAuthor

serhiy-storchakaOct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seebpo-7317/#51566.

Doc/c-api/exceptions.rst

Comment on lines +101 to +102

		.. versionchanged:: 3.8
		Use :func:`sys.unraisablehook`.

Copy link

MemberAuthor

serhiy-storchakaOct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seebpo-36829/#81010.

Doc/c-api/exceptions.rst Outdated

Comment on lines 95 to 96

		.. versionchanged:: 3.2
		Accept ``NULL`` as argument.

Copy link

MemberAuthor

serhiy-storchakaOct 29, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actually, it was cosmetic change. It skipped " in <NULL>" if obj is NULL.

vstinner approved these changes

Oct 30, 2023

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. I just made a minor coding style suggestion.

Modules/_testcapi/exceptions.c OutdatedShow resolvedHide resolved

bedevere-appbot added awaiting merge and removed awaiting core review labels

Oct 30, 2023

Update Modules/_testcapi/exceptions.c

900b74b

Co-authored-by: Victor Stinner <vstinner@python.org>

Copy link

MemberAuthor

serhiy-storchaka commentedOct 30, 2023

Thank you Victor for your review.

serhiy-storchaka merged commitbca3305 intopython:main

Oct 30, 2023

Copy link

miss-islington-appbot commentedOct 30, 2023

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

bedevere-appbot removed the awaiting merge label

Oct 30, 2023

serhiy-storchaka deleted the test-capi-PyErr_WriteUnraisable branch

October 30, 2023 17:01

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 30, 2023

pythongh-108082: C API: Add tests for PyErr_WriteUnraisable() (python…

88d383b

…GH-111455)Also document the behavior when called with NULL.(cherry picked from commitbca3305)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Copy link

bedevere-appbot commentedOct 30, 2023

GH-111507 is a backport of this pull request to the3.12 branch.

bedevere-appbot removed the needs backport to 3.12only security fixes label

Oct 30, 2023

serhiy-storchaka added a commit that referenced this pull request

Oct 30, 2023

[3.12]gh-108082: C API: Add tests for PyErr_WriteUnraisable() (GH-11…

748bc48

…1455) (GH-111507)Also document the behavior when called with NULL.(cherry picked from commitbca3305)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

FullteaR pushed a commit to FullteaR/cpython that referenced this pull request

Nov 3, 2023

pythongh-108082: C API: Add tests for PyErr_WriteUnraisable() (python…

4071691

…GH-111455)Also document the behavior when called with NULL.

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024

pythongh-108082: C API: Add tests for PyErr_WriteUnraisable() (python…

e262ba6

…GH-111455)Also document the behavior when called with NULL.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024

pythongh-108082: C API: Add tests for PyErr_WriteUnraisable() (python…

a87ec4c

…GH-111455)Also document the behavior when called with NULL.

Labels

docs

Documentation in the Doc dir

skip news tests

Tests in the Lib/test dir

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-108082: C API: Add tests for PyErr_WriteUnraisable()#111455

gh-108082: C API: Add tests for PyErr_WriteUnraisable()#111455

Uh oh!

Conversation

serhiy-storchaka commentedOct 29, 2023•
edited by github-actionsbot
Loading

Uh oh!

Uh oh!

serhiy-storchakaOct 29, 2023

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaOct 29, 2023

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaOct 29, 2023•
edited
Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

serhiy-storchaka commentedOct 30, 2023

Uh oh!

miss-islington-appbot commentedOct 30, 2023

Uh oh!

bedevere-appbot commentedOct 30, 2023

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

gh-108082: C API: Add tests for PyErr_WriteUnraisable()#111455

gh-108082: C API: Add tests for PyErr_WriteUnraisable()#111455

Uh oh!

Conversation

serhiy-storchaka commentedOct 29, 2023• edited by github-actionsbotLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

serhiy-storchakaOct 29, 2023

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaOct 29, 2023

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaOct 29, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

serhiy-storchaka commentedOct 30, 2023

Uh oh!

miss-islington-appbot commentedOct 30, 2023

Uh oh!

bedevere-appbot commentedOct 30, 2023

Uh oh!

Uh oh!

serhiy-storchaka commentedOct 29, 2023•
edited by github-actionsbot
Loading

serhiy-storchakaOct 29, 2023•
edited
Loading