Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-101100: Fix sphinx warnings inlibrary/asyncio-dev.rst#111179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@sobolevn for the PR. I've added a small clarification to the attribute definition.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
willingc approved these changesOct 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 22, 2023
…thonGH-111179)*pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`* Update Doc/library/asyncio-eventloop.rst* Update Doc/library/asyncio-eventloop.rst---------(cherry picked from commit8c689c9)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 22, 2023
…thonGH-111179)*pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`* Update Doc/library/asyncio-eventloop.rst* Update Doc/library/asyncio-eventloop.rst---------(cherry picked from commit8c689c9)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
GH-111185 is a backport of this pull request to the3.12 branch. |
GH-111186 is a backport of this pull request to the3.11 branch. |
willingc added a commit that referenced this pull requestOct 22, 2023
…H-111179) (#111185)gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst` (GH-111179)*gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`* Update Doc/library/asyncio-eventloop.rst* Update Doc/library/asyncio-eventloop.rst---------(cherry picked from commit8c689c9)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
willingc added a commit that referenced this pull requestOct 22, 2023
…H-111179) (#111186)gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst` (GH-111179)*gh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`* Update Doc/library/asyncio-eventloop.rst* Update Doc/library/asyncio-eventloop.rst---------(cherry picked from commit8c689c9)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…thonGH-111179)*pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`* Update Doc/library/asyncio-eventloop.rst* Update Doc/library/asyncio-eventloop.rst---------Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…thonGH-111179)*pythongh-101100: Fix sphinx warnings in `library/asyncio-dev.rst`* Update Doc/library/asyncio-eventloop.rst* Update Doc/library/asyncio-eventloop.rst---------Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Please, note that this change is not about
asyncio-eventloop.rst, but is aboutasyncio-dev.rstwhich just happens to referenceasyncio-eventloop.rst:I've also fixed one
asyncio-eventloop.rstproblem, which cannot be detected by Sphinx (just because I saw it):I've moved the
.. versionchangedinside the function body.In the next PR I will fix warnings specific to
asyncio-eventloop.rst.📚 Documentation preview 📚:https://cpython-previews--111179.org.readthedocs.build/