Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-111046: for wasi-threads, export memory as well#111099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
erlend-aasland commentedOct 20, 2023
I'll let Brett (or another WASI expert) take care of this. The |
brettcannon approved these changesOct 20, 2023
Thanks@yamt for the PR, and@brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Member
brettcannon commentedOct 20, 2023
@yamt thanks! |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 20, 2023
…er (pythonGH-111099)(cherry picked from commit5dfa717)Co-authored-by: YAMAMOTO Takashi <yamamoto@midokura.com>
GH-111141 is a backport of this pull request to the3.12 branch. |
brettcannon pushed a commit that referenced this pull requestOct 20, 2023
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
with the latest spec, we should import and export memory for wasi-threads.
some runtimes (eg. wasmtime) actually rely on it.
issue:#111046
tested with: toywasm, wasmtime