Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-110964: clinic: refactor output_templates()#110982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:clinic_output_templates
Oct 20, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedOct 17, 2023•
edited by bedevere-appbot
Loading

@vstinner
Copy link
MemberAuthor

Refactor the code to avoidif clinic is not None. This change basically just move code and removeif clinic is not None.

@vstinnervstinnerforce-pushed theclinic_output_templates branch from3f5b550 toe6cebdbCompareOctober 17, 2023 12:49
@vstinner
Copy link
MemberAuthor

cc@AlexWaygood

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are you fine with this,@AlexWaygood?

@AlexWaygood
Copy link
Member

Are you fine with this,@AlexWaygood?

Haven't had a chance to review in depth, but this looks fine to me -- feel free to merge if you're happy!

@vstinnervstinner merged commit0937b11 intopython:mainOct 20, 2023
@vstinnervstinner deleted the clinic_output_templates branchOctober 20, 2023 21:42
@vstinner
Copy link
MemberAuthor

Merged, thanks for reviews.

aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@AlexWaygood@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp