Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-109894: Fix initialization of staticMemoryError in subinterpreter#110911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ericsnowcurrently merged 4 commits intopython:mainfromchgnrdv:fix-memory-error-crash-in-subinterpOct 23, 2023
Merged
gh-109894: Fix initialization of staticMemoryError in subinterpreter#110911
ericsnowcurrently merged 4 commits intopython:mainfromchgnrdv:fix-memory-error-crash-in-subinterpOct 23, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fixes#109894* set `interp.static_objects.last_resort_memory_error.args` to empty tuple to avoid crash on `PyErr_Display()` call* allow `_PyExc_InitGlobalObjects()` to be called on subinterpreter init
This comment was marked as outdated.
This comment was marked as outdated.
ericsnowcurrently approved these changesOct 23, 2023
Member
ericsnowcurrently left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Member
ericsnowcurrently commentedOct 23, 2023
Thanks,@chgnrdv! |
Thanks@chgnrdv for the PR, and@ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 23, 2023
…erpreter (pythongh-110911)FixespythonGH-109894* set `interp.static_objects.last_resort_memory_error.args` to empty tuple to avoid crash on `PyErr_Display()` call* allow `_PyExc_InitGlobalObjects()` to be called on subinterpreter init---------(cherry picked from commit47d3e2e)Co-authored-by: Radislav Chugunov <52372310+chgnrdv@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
GH-111238 is a backport of this pull request to the3.12 branch. |
ContributorAuthor
chgnrdv commentedOct 24, 2023
@ericsnowcurrently thanks for review :) |
ericsnowcurrently pushed a commit that referenced this pull requestNov 28, 2023
…terpreter (gh-110911) (gh-111238)FixesGH-109894* set `interp.static_objects.last_resort_memory_error.args` to empty tuple to avoid crash on `PyErr_Display()` call* allow `_PyExc_InitGlobalObjects()` to be called on subinterpreter init---------(cherry picked from commit47d3e2e)Co-authored-by: Radislav Chugunov <52372310+chgnrdv@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…erpreter (pythongh-110911)Fixespython#109894* set `interp.static_objects.last_resort_memory_error.args` to empty tuple to avoid crash on `PyErr_Display()` call* allow `_PyExc_InitGlobalObjects()` to be called on subinterpreter init---------Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…erpreter (pythongh-110911)Fixespython#109894* set `interp.static_objects.last_resort_memory_error.args` to empty tuple to avoid crash on `PyErr_Display()` call* allow `_PyExc_InitGlobalObjects()` to be called on subinterpreter init---------Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#109894
interp.static_objects.last_resort_memory_error.argsto empty tuple to avoid crash onPyErr_Display()call_PyExc_InitGlobalObjects()to be called on subinterpreter initMemoryErrorraised throughPyErr_NoMemory()from subinterpreter #109894