Oct 13, 2023 · Oct 12, 2023 · Oct 13, 2023 · Oct 13, 2023 · Oct 13, 2023 · Oct 13, 2023
diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py
        self._clock_resolution = time.get_clock_info('monotonic').resolution
        self._exception_handler = None
        self.set_debug(coroutines._is_debug_mode())
        # The preserved state of async generator hooks.
        self._old_agen_hooks = None
        # In debug mode, if the execution of a callback or a step of a task
        # exceed this duration in seconds, the slow callback/task is logged.
        self.slow_callback_duration = 0.1
                'Cannot run the event loop while another loop is running')

    def run_forever_setup(self):
        """Set up an event loop so that it is ready to start actively looping
        to process events.
        """Prepare the run loop to process events.

        Returns the state that must be restored when the loop concludes. This state
        should be passed in as arguments to ``run_forever_cleanup()``.

        This method is only needed if you are writing your own event loop, with
        customized ``run_forever`` semantics (e.g., integrating a GUI event loop
        with Python's event loop).
        This method should be used as part of the ``run_forever()``
        implementation in a custom event loop subclass (e.g., integrating a GUI
        event loop with Python's event loop).
        """
        self._check_closed()
        self._check_running()
        self._set_coroutine_origin_tracking(self._debug)

 old_agen_hooks = sys.get_asyncgen_hooks()
 self._old_agen_hooks = sys.get_asyncgen_hooks()
        self._thread_id = threading.get_ident()
        sys.set_asyncgen_hooks(
            firstiter=self._asyncgen_firstiter_hook,

        events._set_running_loop(self)

        return (old_agen_hooks,)

    def run_forever_cleanup(self, original_state):
        """Clean up an event loop after the event loop finishes the looping over
        events.

        Restores any state preserved by ``run_forever_setup()``.
    def run_forever_cleanup(self):
        """Clean up after an event loop finishes the looping over events.

        This methodis only needed if you are writing your own event loop, with
 customized ``run_forever`` semantics(e.g., integrating a GUI event loop
        with Python's event loop).
        This methodshould be used as part of the ``run_forever()``
 implementation in a custom event loop subclass(e.g., integrating a GUI
 event loopwith Python's event loop).
        """
        self._stopping = False
        self._thread_id = None
        events._set_running_loop(None)
        self._set_coroutine_origin_tracking(False)
        if original_state is not None:
            old_agen_hooks, = original_state
            sys.set_asyncgen_hooks(*old_agen_hooks)
        # Restore any pre-existing async generator hooks.
        if self._old_agen_hooks is not None:
            sys.set_asyncgen_hooks(*self._old_agen_hooks)
            self._old_agen_hooks = None

    def run_forever(self):
        """Run until stop() is called."""
        # Ensure original_state has a value in case setup fails.
        original_state = None
        try:
 original_state =self.run_forever_setup()
            self.run_forever_setup()
            while True:
                self._run_once()
                if self._stopping:
                    break
        finally:
            self.run_forever_cleanup(original_state)
            self.run_forever_cleanup()

    def run_until_complete(self, future):
        """Run until the Future is done.
diff --git a/Lib/test/test_asyncio/test_base_events.py b/Lib/test/test_asyncio/test_base_events.py
        self.loop.call_soon(callback)

        # Set up the custom event loop
 orig_state =self.loop.run_forever_setup()
        self.loop.run_forever_setup()

        # Confirm the loop has been started
        self.assertEqual(asyncio.get_running_loop(), self.loop)
            self.loop._run_once()

        # Clean up the event loop
        self.loop.run_forever_cleanup(orig_state)
        self.loop.run_forever_cleanup()

        # Confirm the loop has been cleaned up
        with self.assertRaises(RuntimeError):
Original file line number	Diff line number	Diff line change
Expand Up		@@ -400,6 +400,8 @@ def __init__(self):
		self._clock_resolution = time.get_clock_info('monotonic').resolution
		self._exception_handler = None
		self.set_debug(coroutines._is_debug_mode())
		# The preserved state of async generator hooks.
		self._old_agen_hooks = None
		# In debug mode, if the execution of a callback or a step of a task
		# exceed this duration in seconds, the slow callback/task is logged.
		self.slow_callback_duration = 0.1
Expand DownExpand Up		@@ -602,21 +604,17 @@ def _check_running(self):
		'Cannot run the event loop while another loop is running')

		def run_forever_setup(self):
		"""Set up an event loop so that it is ready to start actively looping
		to process events.
		"""Prepare the run loop to process events.

		Returns the state that must be restored when the loop concludes. This state
		should be passed in as arguments to ``run_forever_cleanup()``.

		This method is only needed if you are writing your own event loop, with
		customized ``run_forever`` semantics (e.g., integrating a GUI event loop
		with Python's event loop).
		This method should be used as part of the ``run_forever()``
		implementation in a custom event loop subclass (e.g., integrating a GUI
		event loop with Python's event loop).
		"""
		self._check_closed()
		self._check_running()
		self._set_coroutine_origin_tracking(self._debug)

		old_agen_hooks = sys.get_asyncgen_hooks()
		self._old_agen_hooks = sys.get_asyncgen_hooks()
		self._thread_id = threading.get_ident()
		sys.set_asyncgen_hooks(
		firstiter=self._asyncgen_firstiter_hook,
Expand All		@@ -625,38 +623,32 @@ def run_forever_setup(self):

		events._set_running_loop(self)

		return (old_agen_hooks,)

		def run_forever_cleanup(self, original_state):
		"""Clean up an event loop after the event loop finishes the looping over
		events.

		Restores any state preserved by ``run_forever_setup()``.
		def run_forever_cleanup(self):
		"""Clean up after an event loop finishes the looping over events.

		This methodis only needed if you are writing your own event loop, with
		customized ``run_forever`` semantics(e.g., integrating a GUI event loop
		with Python's event loop).
		This methodshould be used as part of the ``run_forever()``
		implementation in a custom event loop subclass(e.g., integrating a GUI
		event loopwith Python's event loop).
		"""
		self._stopping = False
		self._thread_id = None
		events._set_running_loop(None)
		self._set_coroutine_origin_tracking(False)
		if original_state is not None:
		old_agen_hooks, = original_state
		sys.set_asyncgen_hooks(*old_agen_hooks)
		# Restore any pre-existing async generator hooks.
		if self._old_agen_hooks is not None:
		sys.set_asyncgen_hooks(*self._old_agen_hooks)
		self._old_agen_hooks = None

		def run_forever(self):
		"""Run until stop() is called."""
Copy link Member gvanrossumOct 13, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Maybe clarify in this docstring that this is what calls setup/cleanup?
		# Ensure original_state has a value in case setup fails.
		original_state = None
		try:
		original_state =self.run_forever_setup()
		self.run_forever_setup()
		while True:
		self._run_once()
		if self._stopping:
		break
		finally:
		self.run_forever_cleanup(original_state)
		self.run_forever_cleanup()

		def run_until_complete(self, future):
		"""Run until the Future is done.
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -936,7 +936,7 @@ def callback():
		self.loop.call_soon(callback)

		# Set up the custom event loop
		orig_state =self.loop.run_forever_setup()
		self.loop.run_forever_setup()

		# Confirm the loop has been started
		self.assertEqual(asyncio.get_running_loop(), self.loop)
Expand All		@@ -947,7 +947,7 @@ def callback():
		self.loop._run_once()

		# Clean up the event loop
		self.loop.run_forever_cleanup(orig_state)
		self.loop.run_forever_cleanup()

		# Confirm the loop has been cleaned up
		with self.assertRaises(RuntimeError):
Expand Down