Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-110771: Decompose run_forever() into parts#110773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gvanrossum merged 12 commits intopython:mainfromfreakboy3742:decomposed-event-loop
Oct 13, 2023
Merged
Changes from1 commit
Commits
Show all changes
12 commits
Select commitHold shift + click to select a range
a0c1fde
Decompose run_forever() into parts to allow external usage.
freakboy3742Oct 12, 2023
67bfc8f
📜🤖 Added by blurb_it.
blurb-it[bot]Oct 13, 2023
3dcf97b
Add docs for run_forever_setup and run_forever_cleanup.
freakboy3742Oct 13, 2023
35271dc
Ensure failures during setup don't prevent cleanup.
freakboy3742Oct 13, 2023
6672f68
Add tests for custom event loop implementation.
freakboy3742Oct 13, 2023
54349c3
Store pre-event loop state as a protected variable.
freakboy3742Oct 13, 2023
e6226a5
Add a missing super() call.
freakboy3742Oct 13, 2023
23852d0
Improvements to docs, including a prototype custom event loop.
freakboy3742Oct 13, 2023
e7f892e
Correct prototype of run_forever_cleanup on Windows Proactor.
freakboy3742Oct 13, 2023
f944944
Merge branch 'main' into decomposed-event-loop
freakboy3742Oct 13, 2023
3143126
Keep the setup/cleanup methods as protected API.
freakboy3742Oct 13, 2023
1b3e3d8
Merge branch 'main' into decomposed-event-loop
freakboy3742Oct 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Ensure failures during setup don't prevent cleanup.
  • Loading branch information
@freakboy3742
freakboy3742 committedOct 13, 2023
commit35271dc9947acb1b8e759a6af253de1e1ffce27d
13 changes: 8 additions & 5 deletionsLib/asyncio/base_events.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -627,7 +627,7 @@ def run_forever_setup(self):

return (old_agen_hooks,)

def run_forever_cleanup(self,orig_state):
def run_forever_cleanup(self,original_state):
"""Clean up an event loop after the event loop finishes the looping over
events.

Expand All@@ -637,23 +637,26 @@ def run_forever_cleanup(self, orig_state):
customized ``run_forever`` semantics (e.g., integrating a GUI event loop
with Python's event loop).
"""
old_agen_hooks, = orig_state
self._stopping = False
self._thread_id = None
events._set_running_loop(None)
self._set_coroutine_origin_tracking(False)
sys.set_asyncgen_hooks(*old_agen_hooks)
if original_state is not None:
old_agen_hooks, = original_state
sys.set_asyncgen_hooks(*old_agen_hooks)

def run_forever(self):
"""Run until stop() is called."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe clarify in this docstring that this is what calls setup/cleanup?

# Ensure original_state has a value in case setup fails.
original_state = None
try:
orig_state = self.run_forever_setup()
original_state = self.run_forever_setup()
while True:
self._run_once()
if self._stopping:
break
finally:
self.run_forever_cleanup(orig_state)
self.run_forever_cleanup(original_state)

def run_until_complete(self, future):
"""Run until the Future is done.
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp