Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-110771: Decompose run_forever() into parts#110773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
12 commits Select commitHold shift + click to select a range
a0c1fde Decompose run_forever() into parts to allow external usage.
freakboy374267bfc8f 📜🤖 Added by blurb_it.
blurb-it[bot]3dcf97b Add docs for run_forever_setup and run_forever_cleanup.
freakboy374235271dc Ensure failures during setup don't prevent cleanup.
freakboy37426672f68 Add tests for custom event loop implementation.
freakboy374254349c3 Store pre-event loop state as a protected variable.
freakboy3742e6226a5 Add a missing super() call.
freakboy374223852d0 Improvements to docs, including a prototype custom event loop.
freakboy3742e7f892e Correct prototype of run_forever_cleanup on Windows Proactor.
freakboy3742f944944 Merge branch 'main' into decomposed-event-loop
freakboy37423143126 Keep the setup/cleanup methods as protected API.
freakboy37421b3e3d8 Merge branch 'main' into decomposed-event-loop
freakboy3742File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
PrevPrevious commit
Merge branch 'main' into decomposed-event-loop
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit1b3e3d88eff6482e5220ea636f0dadd858cd86ef
There are no files selected for viewing
This merge commit was added into this branch cleanly.
There are no new changes to show, but you can stillview the diff.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.