Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-110722: Add PYTHON_PRESITE to import a module before site.py is run#110769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 10 commits intopython:mainfromambv:gh-110722-presite
Oct 14, 2023

Conversation

ambv
Copy link
Contributor

@ambvambv commentedOct 12, 2023
edited by github-actionsbot
Loading

… before site.py is runThis is only available --with-pydebug.
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It may be interesting to make this feature to release build.

For the doc, I suggest to replacepackage.module withmodule. You can explain in the doc that the argument can be a module of a package, with an example. I don't know.

Overall, the implementation looks correct.

Copy link
Member

@gpsheadgpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - some minor cleanup to do, feel free to merge after that if CI says "ano" (CZ)

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm fine with the C implementation and the overall feature, I just have some remarks on the doc.

I suggest to replacesite.py withthe site module. In Sphinx, you can even create a link if you want:

the :mod:`site` module

The presite module isimported, it's exactlyrun. But I'm fine withrun_presite name :-) Well, in fact, it can be seed as being "run" ;-)

@ambvambv merged commit84b7e9e intopython:mainOct 14, 2023
@vstinner
Copy link
Member

Congrats!

ambv reacted with heart emoji

@ambvambv deleted the gh-110722-presite branchOctober 15, 2023 17:00
@ambvambv restored the gh-110722-presite branchOctober 25, 2023 12:13
@ambvambv deleted the gh-110722-presite branchNovember 1, 2023 13:15
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpsheadgpsheadgpshead left review comments

@vstinnervstinnervstinner left review comments

@MrPiNkY2022MrPiNkY2022MrPiNkY2022 approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ambv@vstinner@gpshead@MrPiNkY2022

[8]ページ先頭

©2009-2025 Movatter.jp