NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-94597: add asyncio.EventLoop#110723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gvanrossum merged 9 commits intopython:mainfromgraingert:add-asyncio-event-loop

Oct 12, 2023

Merged

gh-94597: add asyncio.EventLoop#110723

gvanrossum merged 9 commits intopython:mainfromgraingert:add-asyncio-event-loop

Oct 12, 2023

Conversation

Copy link

Contributor

graingert commentedOct 11, 2023•
edited by github-actionsbot
Loading

Issue:deprecate the asyncio child watchers system #94597

📚 Documentation preview 📚:https://cpython-previews--110723.org.readthedocs.build/

pythonGH-94597add asyncio.EventLoop

d2f7090

bedevere-appbot mentioned this pull request

Oct 11, 2023

deprecate the asyncio child watchers system#94597

Closed

📜🤖 Added by blurb_it.

47ea029

graingert commented

Oct 11, 2023

View reviewed changes

Doc/library/asyncio-eventloop.rst OutdatedShow resolvedHide resolved

Update Doc/library/asyncio-eventloop.rst

dc9cfee

Copy link

ContributorAuthor

graingert commentedOct 11, 2023•
edited
Loading

This allows running asyncio coroutines without interacting with the policy system eg:

asyncio.run(main(),loop_factory=asyncio.EventLoop)# no need to call asyncio.set_event_loop_policy(None) !

this allows code to run without interfering with a policy that has been set in one location especially one that expectsasyncio.set_event_loop() to be called after every invocation ofasyncio.new_event_loop()

graingert added2 commits

October 11, 2023 16:14

add EventLoop to relevant __all__s

2beab6e

add missing sys import

6290284

graingert changed the title~~GH-94597 add asyncio.EventLoop~~gh-94597: add asyncio.EventLoop

Oct 11, 2023

graingert marked this pull request as ready for review

October 11, 2023 16:07

graingert requested review from1st1,asvetlov,gvanrossum,kumaraditya303 andwillingc ascode owners

October 11, 2023 16:07

bedevere-appbot added the awaiting review label

Oct 11, 2023

Merge branch 'main' into add-asyncio-event-loop

ac27e15

gvanrossum reviewed

Oct 12, 2023

View reviewed changes

Copy link

Member

gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do you intend this to be merged before or after the deprecations PR?

Doc/library/asyncio-eventloop.rst Outdated

Comment on lines 1728 to 1729

		Uses the most efficient available event loop for the given
		platform.

Copy link

Member

gvanrossumOct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this ought to explain that it's an alias for one of the above classes, and that it's the one used by default, and that it's selected the way described above (L1689-90). "Uses" doesn't even explain that it's a subclass of AbstractEventLoop.

Maybe we should be less specific about how the default is selected, and probably whatever we say about it should be only said once, but it should be made clear that this class is the default, and the default is this class.

Misc/NEWS.d/next/Library/2023-10-11-15-07-21.gh-issue-94597.NbPC8t.rst OutdatedShow resolvedHide resolved

Update Misc/NEWS.d/next/Library/2023-10-11-15-07-21.gh-issue-94597.Nb…

ad2c22c

…PC8t.rstCo-authored-by: Guido van Rossum <gvanrossum@gmail.com>

graingert commented

Oct 12, 2023

View reviewed changes

Doc/library/asyncio-eventloop.rst Outdated

Comment on lines 1728 to 1729

		Uses the most efficient available event loop for the given
		platform.

Copy link

ContributorAuthor

graingertOct 12, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

maybe something like this? The other classes don't explain that they are subclasses of AbstractEventLoop, should that be explained in ProactorEventLoop and SelectorEventLoop?

Suggested change

	Uses the most efficient available event loop for the given
	platform.
	Uses the most efficient available event loop for the given
	platform.

	It is an alias for:class:`SelectorEventLoop` on Unix and:class:`ProactorEventLoop` on Windows.

Copy link

Member

gvanrossumOct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not quite. I don't like any sentence describing a class object starting with "Uses". Classes are nouns, and the description should explain what the classis, not what itdoes. Also, the current algorithm for choosing a default is now specified in two places. I think it should be specified only here (and the earlier text should be changed to claim thatEventLoop is the class used by default).

It's also a good idea to clarify that both concrete classes are subclasses ofAbstractEventLoop (but if you're tired of going around in review you can skip that).

Copy link

ContributorAuthor

graingertOct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ok I've pushed a change with some doc tweaks

Copy link

ContributorAuthor

graingert commentedOct 12, 2023•
edited
Loading

Do you intend this to be merged before or after the deprecations PR?

I don't mind what order the PRs go in - I plan a cleanup PR for the CPython test suite removing redundant calls toset_event_loop_policy(None) onceasyncio.EventLoop is available for use inasyncio.run calls

asyncio.EventLoop docs clarification

27d96ca

vstinner reviewed

Oct 12, 2023

View reviewed changes

Doc/library/asyncio-eventloop.rst OutdatedShow resolvedHide resolved

graingert commented

Oct 12, 2023

View reviewed changes

Doc/library/asyncio-eventloop.rst OutdatedShow resolvedHide resolved

remove .. availability tag from asyncio.EventLoop

afaecf2

it's always available

kumaraditya303 self-assigned this

Oct 12, 2023

gvanrossum approved these changes

Oct 12, 2023

View reviewed changes

Copy link

Member

gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Merging now.

bedevere-appbot added awaiting core review and removed awaiting review labels

Oct 12, 2023

gvanrossum approved these changes

Oct 12, 2023

View reviewed changes

gvanrossum merged commit8c6c14b intopython:main

Oct 12, 2023

bedevere-appbot removed the awaiting core review label

Oct 12, 2023

graingert deleted the add-asyncio-event-loop branch

October 12, 2023 14:14

Copy link

Member

vstinner commentedOct 12, 2023

It is an alias to :class:SelectorEventLoop on Unix and :class:ProactorEventLoop on Windows.

Well. In the early days of tulip/asyncio, there were more choices, and we didn't know how third-party projects will inherit/override these classes. Now I agree that asyncio.EventLoop is the way to go, it's easier to remind, it's more explicit, and it's easy to guess what is it (SelectorEventLoop or ProactorEventLoop).

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024

pythongh-94597: Add asyncio.EventLoop (python#110723)

356e4bb

This is needed to pave the way for deprecating and eventually killing the event loop policy system (which is over-engineered and rarely used).

Labels

None yet

4 participants

Movatterモバイル変換

Uh oh!

gh-94597: add asyncio.EventLoop#110723

gh-94597: add asyncio.EventLoop#110723

Uh oh!

Conversation

graingert commentedOct 11, 2023• edited by github-actionsbotLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

graingert commentedOct 11, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossumOct 12, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

graingertOct 12, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gvanrossumOct 12, 2023

Choose a reason for hiding this comment

Uh oh!

graingertOct 12, 2023

Choose a reason for hiding this comment

Uh oh!

graingert commentedOct 12, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commentedOct 12, 2023

Uh oh!

Uh oh!

graingert commentedOct 11, 2023•
edited by github-actionsbot
Loading

graingert commentedOct 11, 2023•
edited
Loading

graingertOct 12, 2023•
edited
Loading

graingert commentedOct 12, 2023•
edited
Loading