Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-85283: _stat extension now uses the limited C API#110711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:limited_stat
Oct 11, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedOct 11, 2023
edited by github-actionsbot
Loading

The _stat C extension is now built with the limited C API.


📚 Documentation preview 📚:https://cpython-previews--110711.org.readthedocs.build/

@vstinner
Copy link
MemberAuthor

@vstinner
Copy link
MemberAuthor

@gpshead
Copy link
Member

I approved as this seems trivial so "lets do it!", obviously figuring out the windows build excitement in CI needs to happen first.

@vstinner
Copy link
MemberAuthor

What's going on? Now Windows build fails with:

LINK : fatal error LNK1104: cannot open file 'python313_d.lib' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

@vstinner
Copy link
MemberAuthor

LINK : fatal error LNK1104: cannot open file 'python313_d.lib' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Ok, I found the root issue and wrote a fix: PRgh-110725. The problem comes from PyAPI_FUNC(), PyAPI_DATA() and PyMODINIT_FUNC macros which have a different implementation depending if the 3 Py_BUILD_CORE macros are defined or not.

gpshead reacted with hooray emoji

@merwokmerwok changed the titlegh-85283: _stat extension uses the limited C APIgh-85283: _stat extension now uses the limited C APIOct 11, 2023
The _stat C extension is now built with the limited C API.
@vstinnervstinner merged commit88ecb19 intopython:mainOct 11, 2023
@vstinnervstinner deleted the limited_stat branchOctober 11, 2023 22:06
@vstinner
Copy link
MemberAuthor

Merged, thanks for the review@gpshead and@erlend-aasland.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…0711)pythongh-85283: _stat extension uses the limited C APIThe _stat C extension is now built with the limited C API.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpsheadgpsheadgpshead approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@gpshead@erlend-aasland

[8]ページ先頭

©2009-2025 Movatter.jp