Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.12] gh-105716: Support Background Threads in Subinterpreters Consistently (gh-109921)#110707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedOct 11, 2023•
edited by bedevere-appbot
Loading

The existence of background threads running on a subinterpreter was preventing interpreters from getting properly destroyed, as well as impacting the ability to run the interpreter again. It also affected how we wait for non-daemon threads to finish.

We add PyInterpreterState.threads.main, with some internal C-API functions.

(cherry-picked from commit1dd9dee)

… Consistently (pythongh-109921)The existence of background threads running on a subinterpreter was preventing interpreters from getting properly destroyed, as well as impacting the ability to run the interpreter again. It also affected how we wait for non-daemon threads to finish.We add PyInterpreterState.threads.main, with some internal C-API functions.(cherry-picked from commit1dd9dee)
@ericsnowcurrentlyericsnowcurrently merged commit0122b4d intopython:3.12Nov 28, 2023
@ericsnowcurrentlyericsnowcurrently deleted the backport-1dd9dee-subinterpreters-allow-background-threads branchNovember 28, 2023 02:01
ericsnowcurrently added a commit that referenced this pull requestNov 28, 2023
gh-110707 (0122b4d) added some tests that didn't close file descriptors they created, leading to failures on the refleak buildbots.  This closes the leaking file descriptors, resolving the failure.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Yhg1sYhg1sYhg1s left review comments

@pablogsalpablogsalpablogsal left review comments

Assignees

@Yhg1sYhg1s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ericsnowcurrently@Yhg1s@pablogsal
[8]ページ先頭
©2009-2025 Movatter.jp