Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-110631: Fix reST indentation inDoc/library#110685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ezio-melotti merged 1 commit intopython:mainfromezio-melotti:fix-ind-library
Oct 11, 2023

Conversation

ezio-melotti
Copy link
Member

@ezio-melottiezio-melotti commentedOct 11, 2023•
edited
Loading

This PR fixes indentation errors that resulted in spuriousblockquotes and definition lists in theDoc/library dir.

📚 Documentation preview 📚:https://cpython-previews--110685.org.readthedocs.build/

Comment on lines -1001 to 1002
*width: width
width: width
The width of the column in pixels.
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This and the next few chunks created a weird definition list with bullets. I removed the bullets to create a regular definition list. The markup of thedts could be improved by adding some``...`` too, to make them stand out more.

@erlend-aasland
Copy link
Contributor

Sphinx indents should be three, not two spaces, no?

@ezio-melotti
Copy link
MemberAuthor

Sphinx indents should be three, not two spaces, no?

I just time-machined an answer for you here:#110635 (comment)

erlend-aasland reacted with heart emoji

@erlend-aaslanderlend-aasland changed the titlegh-110631: fix wrong indentation in theDoc/library dir.gh-110631: Fix reST indentation in theDoc/library dirOct 11, 2023
@ezio-melottiezio-melotti changed the titlegh-110631: Fix reST indentation in theDoc/library dirgh-110631: Fix reST indentation inDoc/libraryOct 11, 2023
@ezio-melottiezio-melotti merged commitbb7923f intopython:mainOct 11, 2023
@miss-islington
Copy link
Contributor

Thanks@ezio-melotti for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@ezio-melotti, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker bb7923f556537a463c403dc1097726d8a8e1a6f2 3.11
ezio-melotti reacted with thumbs down emoji

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 11, 2023
Fix wrong indentation in the Doc/library dir.(cherry picked from commitbb7923f)Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@bedevere-app
Copy link

GH-110736 is a backport of this pull request to the3.12 branch.

ezio-melotti reacted with thumbs up emoji

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelOct 11, 2023
ezio-melotti added a commit to ezio-melotti/cpython that referenced this pull requestOct 11, 2023
…GH-110685)Fix wrong indentation in the Doc/library dir..(cherry picked from commitbb7923f)Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@bedevere-app
Copy link

GH-110737 is a backport of this pull request to the3.11 branch.

ezio-melotti reacted with rocket emoji

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelOct 11, 2023
ezio-melotti added a commit that referenced this pull requestOct 11, 2023
…110736)gh-110631: Fix reST indentation in `Doc/library` (GH-110685)Fix wrong indentation in the Doc/library dir.(cherry picked from commitbb7923f)Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti added a commit that referenced this pull requestOct 11, 2023
…110737)* [3.11]gh-110631: Fix reST indentation in `Doc/library` (GH-110685)Fix wrong indentation in the Doc/library dir..(cherry picked from commitbb7923f)Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>* Fix merge glitch.
@ezio-melottiezio-melotti deleted the fix-ind-library branchOctober 11, 2023 21:11
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@hugovkhugovkhugovk approved these changes

@pradyunsgpradyunsgAwaiting requested review from pradyunsg

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman is a code owner

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees

@ezio-melottiezio-melotti

Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ezio-melotti@erlend-aasland@miss-islington@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp