Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-110525: CoverPySet_Add corner case withfrozenset objects#110544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 4 commits intopython:mainfromsobolevn:issue-110525-2
Oct 9, 2023

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedOct 9, 2023•
edited by bedevere-appbot
Loading

This corner case cannot be covered from Python code, as far as I can tell. But, it is documented:

   Also works with:class:`frozenset`   instances (like:c:func:`PyTuple_SetItem` it can be used to fill in the values   of brand new frozensets before they are exposed to other code).

So, I think we need to test it as well in C code. Sorry for missing this in the original PR!

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is a leak ofnum.

@sobolevn
Copy link
MemberAuthor

sobolevn commentedOct 9, 2023•
edited
Loading

Thanks for the catch! Fixed.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, andfs.

@sobolevn
Copy link
MemberAuthor

Counting references in your head is exausting!
If only we had better languages for this 🐍 🦀

@serhiy-storchaka
Copy link
Member

Then we probably wouldn't need Python.

sobolevn reacted with laugh emoji

@serhiy-storchakaserhiy-storchaka merged commitea39c87 intopython:mainOct 9, 2023
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.12only security fixes labelOct 9, 2023
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 9, 2023
…ythonGH-110544)(cherry picked from commitea39c87)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

GH-110554 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelOct 9, 2023
serhiy-storchaka pushed a commit that referenced this pull requestOct 9, 2023
…H-110544) (GH-110554)(cherry picked from commitea39c87)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sobolevn@serhiy-storchaka@miss-islington
[8]ページ先頭
©2009-2025 Movatter.jp