Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-110519: Improve deprecation warning in the gettext module#110520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Deprecation warning about non-integer number in gettext now alwais refersto the line in the user code where gettext function or method is used.Previously it could refer to a line in gettext code.Also, increase test coverage for NullTranslations and domain-aware functionslike dngettext().
Thanks@serhiy-storchaka for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
GH-110563 is a backport of this pull request to the3.12 branch. |
GH-110564 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 9, 2023
…ythonGH-110520)Deprecation warning about non-integer numbers in gettext now always refersto the line in the user code where gettext function or method is used.Previously, it could refer to a line in gettext code.Also, increase test coverage for NullTranslations and domain-aware functionslike dngettext().(cherry picked from commit326c6c4)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 9, 2023
…ythonGH-110520)Deprecation warning about non-integer numbers in gettext now always refersto the line in the user code where gettext function or method is used.Previously, it could refer to a line in gettext code.Also, increase test coverage for NullTranslations and domain-aware functionslike dngettext().(cherry picked from commit326c6c4)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ambv pushed a commit that referenced this pull requestOct 9, 2023
…H-110520) (GH-110564)Deprecation warning about non-integer numbers in gettext now always refersto the line in the user code where gettext function or method is used.Previously, it could refer to a line in gettext code.Also, increase test coverage for NullTranslations and domain-aware functionslike dngettext().(cherry picked from commit326c6c4)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ambv pushed a commit that referenced this pull requestOct 9, 2023
…H-110520) (GH-110563)Deprecation warning about non-integer numbers in gettext now always refersto the line in the user code where gettext function or method is used.Previously, it could refer to a line in gettext code.Also, increase test coverage for NullTranslations and domain-aware functionslike dngettext().(cherry picked from commit326c6c4)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…ython#110520)Deprecation warning about non-integer numbers in gettext now always refersto the line in the user code where gettext function or method is used.Previously, it could refer to a line in gettext code.Also, increase test coverage for NullTranslations and domain-aware functionslike dngettext().
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Deprecation warning about non-integer number in gettext now alwais refers to the line in the user code where gettext function or method is used. Previously it could refer to a line in gettext code.
Also, increase test coverage for NullTranslations and domain-aware functions like dngettext().