Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-89902: Deprecate non-standard format specifier "N" for Decimal#110508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedOct 7, 2023
edited by github-actionsbot
Loading

It was not documented and only supported in the C implementation.


📚 Documentation preview 📚:https://cpython-previews--110508.org.readthedocs.build/

It was not documented and only supported in the C implementation.
Copy link
Member

@mdickinsonmdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code LGTM, and I agree with the change.

@rhettingerrhettinger removed their request for reviewOctober 7, 2023 23:35
Copy link
Member

@mdickinsonmdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Trying again: LGTM

(Something funny is going on with our automation here. Why is this labelled as "awaiting core review"?)

@serhiy-storchaka
Copy link
MemberAuthor

Ignore it. The bot is broken for months already.

Thank you for your review.

@serhiy-storchakaserhiy-storchaka merged commitd96a8cd intopython:mainOct 8, 2023
@serhiy-storchakaserhiy-storchaka deleted the deprecate-decimal-format-N branchOctober 8, 2023 07:01
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora Clang 3.x has failed when building commitd96a8cd.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/3/builds/4770) and take a look at the build logs.
  4. Check if the failure is related to this commit (d96a8cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/3/builds/4770

Failed tests:

  • test_subprocess

Failed subtests:

  • test_pipesize_default - test.test_subprocess.ProcessTestCaseNoPoll.test_pipesize_default
  • test_pipesizes - test.test_subprocess.ProcessTestCaseNoPoll.test_pipesizes
  • test_pipesize_default - test.test_subprocess.ProcessTestCase.test_pipesize_default
  • test_pipesizes - test.test_subprocess.ProcessTestCase.test_pipesizes

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/test_subprocess.py", line769, intest_pipesize_defaultself.assertEqual(AssertionError:65536 != 8192Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/test_subprocess.py", line727, intest_pipesizes    p= subprocess.Popen(^^^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/subprocess.py", line992, in__init__    errread, errwrite)=self._get_handles(stdin, stdout, stderr)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/subprocess.py", line1731, in_get_handles    fcntl.fcntl(errwrite, fcntl.F_SETPIPE_SZ,self.pipesize)PermissionError:[Errno 1] Operation not permitted

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Fedora Stable LTO + PGO 3.x has failed when building commitd96a8cd.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/524/builds/4666) and take a look at the build logs.
  4. Check if the failure is related to this commit (d96a8cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/524/builds/4666

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_select - test.test_os.TimerfdTests.test_timerfd_select

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/test_os.py", line4085, intest_timerfd_selectself.assertGreater(t, total_time)AssertionError:0.49994910099485423 not greater than 0.5

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 RHEL8 LTO 3.x has failed when building commitd96a8cd.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/338/builds/5284) and take a look at the build logs.
  4. Check if the failure is related to this commit (d96a8cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/338/builds/5284

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_os.py", line4058, intest_timerfd_TFD_TIMER_ABSTIMEself.assertGreater(t, offset)AssertionError:0.9999961559951771 not greater than 1

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu Shared 3.x has failed when building commitd96a8cd.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/506/builds/6083) and take a look at the build logs.
  4. Check if the failure is related to this commit (d96a8cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/506/builds/6083

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_ns_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_ns_TFD_TIMER_ABSTIME
  • test_timerfd_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_os.py", line4211, intest_timerfd_ns_TFD_TIMER_ABSTIMEself.assertGreater(t, offset_ns)AssertionError:999973587 not greater than 1000000000Traceback (most recent call last):  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_os.py", line4058, intest_timerfd_TFD_TIMER_ABSTIMEself.assertGreater(t, offset)AssertionError:0.9999069161713123 not greater than 1

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotPPC64LE Fedora Stable Clang 3.x has failed when building commitd96a8cd.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/435/builds/3713) and take a look at the build logs.
  4. Check if the failure is related to this commit (d96a8cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/435/builds/3713

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_ns_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_ns_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang/build/Lib/test/test_os.py", line4211, intest_timerfd_ns_TFD_TIMER_ABSTIMEself.assertGreater(t, offset_ns)AssertionError:999993323 not greater than 1000000000

Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…al (pythonGH-110508)It was not documented and only supported in the C implementation.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdickinsonmdickinsonmdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@serhiy-storchaka@bedevere-bot@mdickinson

[8]ページ先頭

©2009-2025 Movatter.jp