Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-110378: Fix test_async_gen_propagates_generator_exit in test_contextlib_async#110500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedOct 7, 2023•
edited by bedevere-appbot
Loading

It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code.

…_contextlib_asyncIt now fails if the original bug is not fixed, and no longer produceResourceWarning with fixed code.
@ambv
Copy link
Contributor

After6780d63 there are no RuntimeWarnings visible on Ubuntu and macOS so I had to revert that to confirm this PR is indeed solving the core issue.

Without the change:

/Volumes/RAMDisk/cpython/Lib/contextlib.py:701: RuntimeWarning: coroutine method 'aclose' of 'TestAbstractAsyncContextManager.test_async_gen_propagates_generator_exit.<locals>.gen' was never awaited  async def __aenter__(self):RuntimeWarning: Enable tracemalloc to get the object allocation traceback

This warning doesn't appear after the change.

@ambvambv merged commit5aa62a8 intopython:mainOct 10, 2023
@miss-islington
Copy link
Contributor

Thanks@serhiy-storchaka for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 10, 2023
…_contextlib_async (pythonGH-110500)It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code.(cherry picked from commit5aa62a8)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-110610 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelOct 10, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 10, 2023
…_contextlib_async (pythonGH-110500)It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code.(cherry picked from commit5aa62a8)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-110611 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelOct 10, 2023
ambv pushed a commit that referenced this pull requestOct 10, 2023
…t_contextlib_async (GH-110500) (#110610)It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code.(cherry picked from commit5aa62a8)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ambv pushed a commit that referenced this pull requestOct 10, 2023
…t_contextlib_async (GH-110500) (#110611)It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code.(cherry picked from commit5aa62a8)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…_contextlib_async (python#110500)It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@1st11st1Awaiting requested review from 1st11st1 is a code owner

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@serhiy-storchaka@ambv@miss-islington
[8]ページ先頭
©2009-2025 Movatter.jp