Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix sphinx warnings inlibrary/getpass.rst#110461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 1 commit intopython:mainfromsobolevn:issue-101100-getpass
Oct 19, 2023

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedOct 6, 2023•
edited by github-actionsbot
Loading

Before:

/Users/sobolev/Desktop/cpython/Doc/library/getpass.rst:45: WARNING: 'envvar' reference target not found: LNAME

I don't think that we need to document this Linux-specific variable.
We don't document any other env vars from this function:

~/Desktop/cpython  main ✗                                                                 » ag '.. envvar:: USER' Doc                                                                                           ~/Desktop/cpython  main ✗                                                              1 ⚠️» ag '.. envvar:: LOG' Doc

But, they are pre-defined in Sphinx, I guess. But, notLNAME.
So, just ignore it.

📚 Documentation preview 📚:https://cpython-previews--110461.org.readthedocs.build/

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Interesting that they don't link anywhere or change the formatting:

image

https://cpython-previews--110461.org.readthedocs.build/en/110461/library/getpass.html#module-getpass

Anyway, thanks, looks good.

@hugovkhugovk merged commitd144749 intopython:mainOct 19, 2023
@miss-islington-app
Copy link

Thanks@sobolevn for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@sobolevn and@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker d144749914dbe295d71d037e8ca695783511123f 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 19, 2023
…GH-110461)(cherry picked from commitd144749)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

GH-111072 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelOct 19, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull requestOct 19, 2023
…ythonGH-110461).(cherry picked from commitd144749)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
hugovk pushed a commit to hugovk/cpython that referenced this pull requestOct 19, 2023
…ythonGH-110461).(cherry picked from commitd144749)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

GH-111080 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelOct 19, 2023
hugovk pushed a commit that referenced this pull requestOct 19, 2023
hugovk added a commit that referenced this pull requestOct 19, 2023
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

@hugovkhugovk

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sobolevn@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp