Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-109286: Updated macOS SQLite installer to 3.43.1#110374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

jtranquilli
Copy link
Contributor

@jtranquillijtranquilli commentedOct 4, 2023
edited by bedevere-appbot
Loading

I updated the macOS SQLite installer, all changes were made in the build-installer.py file. I'll be doing the Windows installer next in a separate PR as requested.

@jtranquillijtranquilli requested a review froma team as acode ownerOctober 4, 2023 23:36
@ghost
Copy link

ghost commentedOct 4, 2023
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

jtranquilli reacted with heart emoji

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

jtranquilli reacted with heart emoji

@erlend-aasland
Copy link
Contributor

erlend-aasland commentedOct 5, 2023
edited
Loading

I updated the macOS SQLite installer, all changes were made in the build-installer.py file. I'll be doing the Windows installer next in a separate PR as requested.

Before doing the Windows PRs, please take a close look at the earlier Windows PRs; your PR should lookvery similar to these:

@erlend-aaslanderlend-aasland added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsOct 5, 2023
@jtranquilli
Copy link
ContributorAuthor

I updated the macOS SQLite installer, all changes were made in the build-installer.py file. I'll be doing the Windows installer next in a separate PR as requested.

Before doing the Windows PRs, please take a close look at the earlier Windows PRs; your PR should lookvery similar to these:

Sounds good, sorry about that. I had messed around with those lines because I was getting a trailing white space error, and then in my previous pr someone had asked me to realign the indentation of extra_cflags, so I thought it was accidentally over-indented. Just out of curiosity, why is the extra indentation preferred in that context?

@jtranquillijtranquilli deleted the macOS-SQLite-installer-upgrade branchOctober 5, 2023 14:40
@erlend-aasland
Copy link
Contributor

Why was this closed?

@erlend-aasland
Copy link
Contributor

Just out of curiosity, why is the extra indentation preferred in that context?

It's not that the extra indentation is preferred; the point is that any change should be as isolated as possible. Any style changes (or other unrelated changes) should be left out.

jtranquilli reacted with heart emoji

@jtranquilli
Copy link
ContributorAuthor

Why was this closed?

It was an accident. I was asked to separate the changes for macOS and Windows into two separate PRs, and despite using different branches for each set of changes, GitHub was not allowing me to create separate PRs for each, so I submitted the PR with the macOS changes, then deleted that branch on my GitHub page so that the changes made in that branch would not be included in my PR for the Windows changes, then submitted the PR for the Windows changes. I didn't realize that deleting the branch on my personal page would close this PR and that was the only work around I could think of to isolate the changes for the two operating systems since Github was seemingly not allowing me to isolate the changes made in each branch into two separate PRs. If you merge the PR I made for the Windows SQLite installer upgrade I'll submit a new PR for the macOS installer upgrades, but other than deleting the branch locally I'm not sure how I can isolate those changes as requested. Sorry for the hassle.

erlend-aasland reacted with thumbs up emoji

@erlend-aasland
Copy link
Contributor

Can you please reopen this PR?

@jtranquilli
Copy link
ContributorAuthor

Can you please reopen this PR?

I'm prevented from doing so because the branch was deleted, re-uploading it doesn't seem to help either. All the requested changes were saved on my local branch though so I'll just create a new pr. Again, sorry for the hassle.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jtranquilli@erlend-aasland

[8]ページ先頭

©2009-2025 Movatter.jp