NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

GH-109369: Add machinery for deoptimizing tier2 executors, both individually and globally.#110358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

markshannon wants to merge6 commits intopython:mainfromfaster-cpython:tier2-deopt

Closed

GH-109369: Add machinery for deoptimizing tier2 executors, both individually and globally.#110358

markshannon wants to merge6 commits intopython:mainfromfaster-cpython:tier2-deopt

Conversation

Copy link

Member

markshannon commentedOct 4, 2023•
edited by bedevere-appbot
Loading

This PR just provides the machinery; we still need to add support to the executors and to make the necessary calls when instrumenting.

The implementation uses abloom filter.
The advantage of a bloom filter is that it requires no coupling between the executors and the objects they depend on, plus it is simpler to implement and uses less memory than a precise mapping.

I've chosen k = 6 and m = 256.
This should give a low enough false positive rate for most cases. We want to keep the false positive rate very low, as spurious de-optimizations could be expensive.