Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-109286 Updated macOS and Windows installers to SQLite 3.43.1#110252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
jtranquilli wants to merge0 commits intopython:mainfromjtranquilli:main

Conversation

@jtranquilli
Copy link
Contributor

Updated macOS and Windows installers to SQLite 3.43.1

I made changes to 4 files following the templated structure for this kind of update which was outlined in previous issues. The files that were changed areMac/BuildScript/build-installer.pyPCbuild/get_externals.batPCbuild/python.propsPCbuild/readme.txt

The issue isgh-109286

@jtranquillijtranquilli requested review froma team ascode ownersOctober 3, 2023 02:57
@ghost
Copy link

ghost commentedOct 3, 2023
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

jtranquilli reacted with thumbs up emoji

@jtranquilli
Copy link
ContributorAuthor

Seems to be having an issue with the checksum variable. I copied that hash code directly from the site :https://sqlite.org/download.html. It is the correct hash assigned to the .tar.gz file for the source code download for version 3.43.1.

Copy link
Contributor

@felixxmfelixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@jtranquilli Thanks 👍 Please split it into two PRs, one for Windows and one for macOS installer.

erlend-aasland reacted with thumbs up emoji
@zware
Copy link
Member

Please split it into two PRs, one for Windows and one for macOS installer.

Doing both in one PR is fine.

There are several failing checks right now, though:

  • CLA Signing — Please sign our Contributor License Agreement.
    Required
    Details
    • This is the most important one; we cannot accept your contribution without a signed license agreement. You may need to configureuser.email correctly in your local.gitconfig file and recreate your commits with the correct user information.
  • bedevere/issue-number — No issue # in title or "skip issue" label found
    Required
    Details
    • This one just needs a rearrangement of the PR title, it should be of the formgh-###: <short description>
  • Lint / lint (pull_request) Failing after 36s
    Details
    • You can run eithermake patchcheck orpre-commit locally, or just copy and apply the patch provided in the output at theDetails link.

@felixxm
Copy link
Contributor

Please split it into two PRs, one for Windows and one for macOS installer.

Doing both in one PR is fine.

I've been asked to do it separately in the past 🤷

@zware
Copy link
Member

Splitting is also fine :). It's largely a matter of personal taste; I'll be happy to merge a unified PR when it's clean and ready, but another core dev may well prefer a split.

@zooba
Copy link
Member

We typically have two separate NEWS entries for these changes, as they affect the release more than build. You can add two entries in the same PR (just change the random characters near the end of the filename), but people are probably going to be more comfortable with one NEWS entry per PR, just because they won't have seen multiple ones so often.

erlend-aasland reacted with thumbs up emoji

@erlend-aasland
Copy link
Contributor

I usually split these PRs, since the response time of the Windows and macOS teams can vary greatly :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please remove this and add two NEWS items; one for macOS, and one for Windows. Also note that it ismacOS, notMacOS.

@jtranquillijtranquilli changed the titleUpdated macOS and Windows installers to SQLite 3.43.1 - Issue #109286gh-109286 Updated macOS and Windows installers to SQLite 3.43.1Oct 3, 2023
@jtranquilli
Copy link
ContributorAuthor

Please split it into two PRs, one for Windows and one for macOS installer.

Doing both in one PR is fine.

There are several failing checks right now, though:

  • CLA Signing — Please sign our Contributor License Agreement.
    Required
    Details

    • This is the most important one; we cannot accept your contribution without a signed license agreement. You may need to configureuser.email correctly in your local.gitconfig file and recreate your commits with the correct user information.
  • bedevere/issue-number — No issue # in title or "skip issue" label found
    Required
    Details

    • This one just needs a rearrangement of the PR title, it should be of the formgh-###: <short description>
  • Lint / lint (pull_request) Failing after 36s
    Details

    • You can run eithermake patchcheck orpre-commit locally, or just copy and apply the patch provided in the output at theDetails link.

I just updated my .gitconfig file to use my GitHub email so that I should be able to sign the CLA now, but this PR is still associated with some other default email. Is the best way forward to create a new pull request with the updated associated email or is there some way to salvage this request?

@zware
Copy link
Member

Depends on the level of Git wizardry that you're comfortable with :). You can recreate the commits and force-push, or you can take the opportunity to split it up and push fresh commits to two new branches and thus new PRs.

erlend-aasland reacted with thumbs up emoji

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland requested changes

+1 more reviewer

@felixxmfelixxmfelixxm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jtranquilli@zware@felixxm@zooba@erlend-aasland

[8]ページ先頭

©2009-2025 Movatter.jp