NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-110014: Include explicitly <unistd.h> header#110155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:unistd3

Sep 30, 2023

Merged

gh-110014: Include explicitly <unistd.h> header#110155

vstinner merged 1 commit intopython:mainfromvstinner:unistd3

Sep 30, 2023

Conversation

Copy link

Member

vstinner commentedSep 30, 2023•
edited by github-actionsbot
Loading

Remove unused <locale.h> include.
Remove <fcntl.h> include in traceback.h.
Remove redundant include: <assert.h> and <stddef.h> are already included by "Python.h".
Remove <object.h> include in faulthandler.c.
Add missing <stdbool.h> in pycore_pythread.h if HAVE_PTHREAD_STUBS is defined.
Fix also warnings in pthread_stubs.h: don't redefine macros if they are already defined, like the __NEED_pthread_t macro.

Issue:GCC warnings on pycore_semaphore.h and Python/parking_lot.c #110014

📚 Documentation preview 📚:https://cpython-previews--110155.org.readthedocs.build/

vstinner added the skip news label

Sep 30, 2023

vstinner requested review fromrhettinger,pablogsal,lysnikolaou andiritkatriel ascode owners

September 30, 2023 19:30

bedevere-appbot added the awaiting review label

Sep 30, 2023

bedevere-appbot mentioned this pull request

Sep 30, 2023

GCC warnings on pycore_semaphore.h and Python/parking_lot.c#110014

Closed

pythongh-110014: Include explicitly <unistd.h> header

d7b3e46

* Remove unused <locale.h> include.* Remove <fcntl.h> include in traceback.h.* Remove redundant include: <assert.h> and <stddef.h> are already  included by "Python.h".* Remove <object.h> include in faulthandler.c.* Add missing <stdbool.h> in pycore_pythread.h if HAVE_PTHREAD_STUBS  is defined.* Fix also warnings in pthread_stubs.h: don't redefine macros if they  are already defined, like the __NEED_pthread_t macro.

vstinner force-pushed theunistd3 branch from85d4c17 tod7b3e46Compare

September 30, 2023 19:36

Copy link

MemberAuthor

vstinner commentedSep 30, 2023

Oh. It seems like WASM/WASI builds are badly broken. I'm not sure if it's related to my commit74e425e or not.

vstinner mentioned this pull request

Sep 30, 2023

gh-110014: Fix _POSIX_THREADS and _POSIX_SEMAPHORES usage#110139

Merged

vstinnerenabled auto-merge (squash)

September 30, 2023 19:57

vstinner merged commit7513994 intopython:main

Sep 30, 2023

vstinner deleted the unistd3 branch

September 30, 2023 20:06

bedevere-appbot removed the awaiting review label

Sep 30, 2023

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024

pythongh-110014: Include explicitly <unistd.h> header (python#110155)

e0f276d

* Remove unused <locale.h> includes.* Remove unused <fcntl.h> include in traceback.h.* Remove redundant <assert.h> and <stddef.h> includes. They  are already  included by "Python.h".* Remove <object.h> include in faulthandler.c. Python.h already includes it.* Add missing <stdbool.h> in pycore_pythread.h if HAVE_PTHREAD_STUBS  is defined.* Fix also warnings in pthread_stubs.h: don't redefine macros if they  are already defined, like the __NEED_pthread_t macro.