NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

[3.12] gh-110088, gh-109878: Fix test_asyncio timeouts (#110092)#110098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:3.12fromvstinner:asyncio_timeout12

Oct 2, 2023

Merged

[3.12] gh-110088, gh-109878: Fix test_asyncio timeouts (#110092)#110098

vstinner merged 1 commit intopython:3.12fromvstinner:asyncio_timeout12

Oct 2, 2023

Conversation

Copy link

Member

vstinner commentedSep 29, 2023•
edited by bedevere-appbot
Loading

Fix test_asyncio timeouts: don't measure the maximum duration, a test should not measure a CI performance. Only measure the minimum duration when a task has a timeout or delay. Add CLOCK_RES to test_asyncio.utils.

(cherry picked from commitdb0a258)

Issue:test_asyncio.test_windows_events: test_wait_for_handle() failed on GHA Windows x86 #110088

vstinner requested review from1st1,asvetlov,gvanrossum,kumaraditya303 andwillingc ascode owners

September 29, 2023 11:53

bedevere-appbot added the awaiting review label

Sep 29, 2023

This was referencedSep 29, 2023

test_asyncio.test_windows_events: test_wait_for_handle() failed on GHA Windows x86#110088

Closed

gh-110088, gh-109878: Fix test_asyncio timeouts#110092

Merged

willingc approved these changes

Sep 29, 2023

View reviewed changes

Copy link

Contributor

willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks to be a nice clean-up and healthy improvement for asyncio tests. +1 from me. Thanks@vstinner

bedevere-appbot added awaiting core review and removed awaiting review labels

Sep 29, 2023

pythongh-110088,pythongh-109878: Fix test_asyncio timeouts (python#1…

7a21cb1

…10092)Fix test_asyncio timeouts: don't measure the maximum duration, a testshould not measure a CI performance. Only measure the minimumduration when a task has a timeout or delay. Add CLOCK_RES totest_asyncio.utils.(cherry picked from commitdb0a258)