NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

Docs: Add the time to the HTML last updated format#110091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 7 commits intopython:mainfromAA-Turner:docs/last-updated-time

Nov 15, 2023

Merged

Docs: Add the time to the HTML last updated format#110091

vstinner merged 7 commits intopython:mainfromAA-Turner:docs/last-updated-time

Nov 15, 2023

Conversation

Copy link

Member

AA-Turner commentedSep 29, 2023•
edited by github-actionsbot
Loading

python/docsbuild-scripts#163

Before:

After:

📚 Documentation preview 📚:https://cpython-previews--110091.org.readthedocs.build/

Add time to the HTML last updated format

5062a66

AA-Turner added docs

Documentation in the Doc dir

skip issue skip news needs backport to 3.11

only security fixes

needs backport to 3.12only security fixes labels

Sep 29, 2023

AA-Turner requested a review fromhugovk

September 29, 2023 10:29

bedevere-appbot added the awaiting review label

Sep 29, 2023

AA-Turner mentioned this pull request

Sep 29, 2023

Increase the build frequency of English HTML stable (and pre-release?) documentationpython/docsbuild-scripts#163

Closed

vstinner approved these changes

Sep 29, 2023

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thank you for today that.

... Do you have access to the timezone?

bedevere-appbot added awaiting core review and removed awaiting review labels

Sep 29, 2023

Copy link

Member

vstinner commentedSep 29, 2023

If you have no timezone information, can we use UTC timestamp?

Copy link

Member

vstinner commentedSep 29, 2023

Is it UTC?

https://github.com/sphinx-doc/sphinx/blob/b9c85984d2f4863e4c09932c746d915e3233507b/sphinx/util/i18n.py#L192-L199

vstinner reviewed

Sep 29, 2023

View reviewed changes

Doc/conf.py OutdatedShow resolvedHide resolved

Add the timezone

8559481

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner approved these changes

Sep 29, 2023

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, even better with the timezone :-)

hugovk approved these changes

Sep 29, 2023

View reviewed changes

Copy link

Member

hugovk commentedSep 29, 2023

👍

AA-Turner added2 commits

September 29, 2023 15:57

Fix timezone information

7ae5336

Formatting

71549e7

hugovk requested changes

Sep 29, 2023

View reviewed changes

Doc/conf.py OutdatedShow resolvedHide resolved

vstinner reviewed

Sep 29, 2023

View reviewed changes

Doc/conf.py OutdatedShow resolvedHide resolved

hugovk reviewed

Sep 30, 2023

View reviewed changes

Doc/conf.py OutdatedShow resolvedHide resolved

AA-Turner added2 commits

October 18, 2023 10:26

Merge branch 'main' into docs/last-updated-time

ea0e82e

Use a static time

605aaaa

Copy link

MemberAuthor

AA-Turner commentedOct 18, 2023

Now:

AA-Turner requested a review fromhugovk

October 18, 2023 09:42

hugovk approved these changes

Oct 18, 2023

View reviewed changes

Copy link

Member

hugovk left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good:

Non-blocking:

I'd still prefer "UTC" instead of "GMT", strictly speaking they're not the same: GMT is a timezone used by some countries, UTC is the standard. And UTC is maybe better known, judging by Google results (GMT: "About 527 000 000 results", UTC: "About 2 550 000 000 results").

bedevere-appbot removed the awaiting core review label

Oct 18, 2023

bedevere-appbot added the awaiting merge label

Oct 18, 2023

vstinner approved these changes

Oct 18, 2023

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Copy link

Member

vstinner commentedOct 18, 2023

Ah right, UTC is better. time.gmtime() is documented to return time inUTC timezone:https://docs.python.org/dev/library/time.html#time.gmtime

vstinner reviewed

Nov 15, 2023

View reviewed changes

Doc/conf.py OutdatedShow resolvedHide resolved

Update Doc/conf.py

85533c6

vstinnerenabled auto-merge (squash)

November 15, 2023 03:56

vstinner merged commit6c214de intopython:main

Nov 15, 2023

Copy link

miss-islington-appbot commentedNov 15, 2023

Thanks@AA-Turner for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-appbot removed the awaiting merge label

Nov 15, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 15, 2023

Docs: Add the time to the HTML last updated format (pythonGH-110091)

58589b8

(cherry picked from commit6c214de)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Copy link

bedevere-appbot commentedNov 15, 2023

GH-112102 is a backport of this pull request to the3.12 branch.

bedevere-appbot removed the needs backport to 3.12only security fixes label

Nov 15, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 15, 2023

Docs: Add the time to the HTML last updated format (pythonGH-110091)

5a65d25

(cherry picked from commit6c214de)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Copy link

bedevere-appbot commentedNov 15, 2023

GH-112103 is a backport of this pull request to the3.11 branch.

bedevere-appbot removed the needs backport to 3.11only security fixes label

Nov 15, 2023

vstinner pushed a commit that referenced this pull request

Nov 15, 2023

[3.12] Docs: Add the time to the HTML last updated format (GH-110091) (…

c190552

…#112102)Docs: Add the time to the HTML last updated format (GH-110091)(cherry picked from commit6c214de)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

vstinner pushed a commit that referenced this pull request

Nov 15, 2023

[3.11] Docs: Add the time to the HTML last updated format (GH-110091) (…

a92b9e5

…#112103)Docs: Add the time to the HTML last updated format (GH-110091)(cherry picked from commit6c214de)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Copy link

Member