Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix sphinx warnings inlibrary/difflib.rst#110074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 1 commit intopython:mainfromsobolevn:issue-101100-difflib
Sep 29, 2023

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedSep 29, 2023•
edited by github-actionsbot
Loading

Before:

/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:571: WARNING: py:meth reference target not found: quick_ratio/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:571: WARNING: py:meth reference target not found: real_quick_ratio/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:571: WARNING: py:meth reference target not found: ratio/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:596: WARNING: py:meth reference target not found: ratio/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:596: WARNING: py:meth reference target not found: ratio/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:603: WARNING: py:meth reference target not found: get_matching_blocks/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:612: WARNING: py:meth reference target not found: get_matching_blocks/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:616: WARNING: py:meth reference target not found: get_opcodes/Users/sobolev/Desktop/cpython/Doc/library/difflib.rst:690: WARNING: py:meth reference target not found: io.BaseIO.readlines

📚 Documentation preview 📚:https://cpython-previews--110074.org.readthedocs.build/

Note that the last tuple returned by :meth:`get_matching_blocks` is always a
dummy, ``(len(a), len(b), 0)``, and this is the only case in which the last
Note that the last tuple returned by :meth:`~SequenceMatcher.get_matching_blocks`
is always adummy, ``(len(a), len(b), 0)``, and this is the only case in which the last
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For next time, let's avoid rewrapping when making changes. It's okay to extend the line length for edits and it's much easier to review with a smaller diff. Thanks!

@hugovkhugovk merged commitd102d39 intopython:mainSep 29, 2023
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@sobolevn and@hugovk, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker d102d39bbe175f179f28e4d4bea99dc122da5f8e 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 29, 2023
…GH-110074)(cherry picked from commitd102d39)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

GH-110081 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelSep 29, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull requestSep 29, 2023
hugovk added a commit to hugovk/cpython that referenced this pull requestSep 29, 2023
…ythonGH-110074).(cherry picked from commitd102d39)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

GH-110082 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelSep 29, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull requestSep 29, 2023
…ythonGH-110074).(cherry picked from commitd102d39)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
hugovk added a commit that referenced this pull requestSep 29, 2023
Yhg1s pushed a commit that referenced this pull requestSep 29, 2023
…0074) (#110081)gh-101100: Fix sphinx warnings in `library/difflib.rst` (GH-110074)(cherry picked from commitd102d39)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

Assignees

@hugovkhugovk

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sobolevn@miss-islington@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp