Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-110036: multiprocessing Popen.terminate() catches PermissionError#110037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…rrorOn Windows, multiprocessing Popen.terminate() now catchsPermissionError and get the process exit code. If the process isstill running, raise again the PermissionError. Otherwise, theprocess terminated as expected: store its exit code.
dbb27f7 to0ed6e0bComparebedevere-bot commentedSep 28, 2023
MemberAuthor
vstinner commentedSep 29, 2023
It failed with: Well, that's unrelated, my code should be specific to Windows. |
Contributor
miss-islington commentedSep 29, 2023
Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 29, 2023
…Error (pythonGH-110037)On Windows, multiprocessing Popen.terminate() now catchsPermissionError and get the process exit code. If the process isstill running, raise again the PermissionError. Otherwise, theprocess terminated as expected: store its exit code.(cherry picked from commitbd4518c)Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 29, 2023
…Error (pythonGH-110037)On Windows, multiprocessing Popen.terminate() now catchsPermissionError and get the process exit code. If the process isstill running, raise again the PermissionError. Otherwise, theprocess terminated as expected: store its exit code.(cherry picked from commitbd4518c)Co-authored-by: Victor Stinner <vstinner@python.org>
GH-110064 is a backport of this pull request to the3.12 branch. |
GH-110065 is a backport of this pull request to the3.11 branch. |
vstinner added a commit that referenced this pull requestSep 29, 2023
…nError (GH-110037) (#110065)gh-110036: multiprocessing Popen.terminate() catches PermissionError (GH-110037)On Windows, multiprocessing Popen.terminate() now catchsPermissionError and get the process exit code. If the process isstill running, raise again the PermissionError. Otherwise, theprocess terminated as expected: store its exit code.(cherry picked from commitbd4518c)Co-authored-by: Victor Stinner <vstinner@python.org>
Yhg1s pushed a commit that referenced this pull requestOct 2, 2023
…nError (GH-110037) (#110064)gh-110036: multiprocessing Popen.terminate() catches PermissionError (GH-110037)On Windows, multiprocessing Popen.terminate() now catchsPermissionError and get the process exit code. If the process isstill running, raise again the PermissionError. Otherwise, theprocess terminated as expected: store its exit code.(cherry picked from commitbd4518c)Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…Error (python#110037)On Windows, multiprocessing Popen.terminate() now catchsPermissionError and get the process exit code. If the process isstill running, raise again the PermissionError. Otherwise, theprocess terminated as expected: store its exit code.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
On Windows, multiprocessing Popen.terminate() now catchs PermissionError and get the process exit code. If the process is still running, raise again the PermissionError. Otherwise, the process terminated as expected: store its exit code.