Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-110014: Fix inconsistent struct definition in pycore_semaphore.h#110030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…re.hThe pycore_semaphore.h header is included by Python/lock.c andPython/parking_lot.c. The macro `_POSIX_SEMAPHORES` was not consistentlydefined across the two files (due to a missing include of `<unistd.h>`)leading to different struct definitions. The RHEL8 ppc64le LTO buildbotcorrectly warned due to this issue.
!buildbot ppc64le |
bedevere-bot commentedSep 28, 2023
The regex 'ppc64le' did not match any buildbot builder.Is the requested builder in the list of stable builders? |
!buildbot lto |
bedevere-bot commentedSep 28, 2023
The regex 'lto' did not match any buildbot builder.Is the requested builder in the list of stable builders? |
bedevere-bot commentedSep 28, 2023
🤖 New build scheduled with the buildbot fleet by@colesbury for commit6e0228b 🤖 If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
|
Oh, maybe the search is case sensitive and you should use |
!buildbot PPC64LE |
bedevere-bot commentedSep 28, 2023
🤖 New build scheduled with the buildbot fleet by@colesbury for commit6e0228b 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
I wrotepython/buildmaster-config#409 to make the search ignores the case. I got bitten multiple times by the |
Thanks! |
@vstinner, would you please review this when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh wait. The problem is way wider than pycore_semaphore.h! _POSIX_THREADS and _POSIX_SEMAPHORES macros are checked in Python/pthread_thread.h, pycore_condvar.h. and pycore_pythread.h without explicitly including <unistd.h>.
I wrote a wider change to attempt to fix all cases: PRgh-110139.
I wrote a more complete fix: PR#110139. Thanks for working on fixing these warnings! |
Uh oh!
There was an error while loading.Please reload this page.
The pycore_semaphore.h header is included by Python/lock.c and Python/parking_lot.c. The macro
_POSIX_SEMAPHORESwas not consistently defined across the two files (due to a missing include of<unistd.h>) leading to different struct definitions. The RHEL8 ppc64le LTO buildbot correctly warned due to this issue.