Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
Comments
Merged
Conversation
MemberAuthor
vstinner commentedSep 28, 2023
@encukou: test_cfunction contains the following commented code: Should we try to reenable it, or remove the test? |
* Split PyBtTests.test_pycfunction() into 2 files, test_cfunction and test_cfunction_full, and 6 functions: * test_pycfunction_noargs() * test_pycfunction_o() * test_pycfunction_varargs() * test_pycfunction_varargs_keywords() * test_pycfunction_fastcall() * test_pycfunction_fastcall_keywords()* In verbose mode, these "pycfunction" tests now log each tested call.* Move get_gdb_repr() to PrettyPrintTests.* Replace DebuggerTests.get_sample_script() with SAMPLE_SCRIPT.* Rename checkout_hook_path to CHECKOUT_HOOK_PATH.* Rename gdb_version to GDB_VERSION_TEXT.* Replace (gdb_major_version, gdb_minor_version) with GDB_VERSION.* run_gdb() uses "backslashreplace" error handler.* Add check_gdb() function to util.py.* Enhance support.check_cflags_pgo(): check also for sysconfig PGO_PROF_USE_FLAG (if available) in compiler flags.* Move some SkipTest checks to test_gdb/__init__.py.* Elaborate why gdb cannot be tested on Windows: gdb doesn't support PDB debug symbol files.
43c3da3 to18029d6CompareMemberAuthor
vstinner commentedSep 28, 2023
macOS failed with: I created issuegh-110033 for this test failure. |
MemberAuthor
vstinner commentedSep 28, 2023
Windows x86 failed with: I created issuegh-110036 for this test failure. |
csm10495 pushed a commit to csm10495/cpython that referenced this pull requestSep 29, 2023
* Split test_pycfunction.py: add test_cfunction_full.py. Split the function into the following 6 functions. In verbose mode, these "pycfunction" tests now log each tested call. * test_pycfunction_noargs() * test_pycfunction_o() * test_pycfunction_varargs() * test_pycfunction_varargs_keywords() * test_pycfunction_fastcall() * test_pycfunction_fastcall_keywords()* Move get_gdb_repr() to PrettyPrintTests.* Replace DebuggerTests.get_sample_script() with SAMPLE_SCRIPT.* Rename checkout_hook_path to CHECKOUT_HOOK_PATH.* Rename gdb_version to GDB_VERSION_TEXT.* Replace (gdb_major_version, gdb_minor_version) with GDB_VERSION.* run_gdb() uses "backslashreplace" error handler instead of "replace".* Add check_gdb() function to util.py.* Enhance support.check_cflags_pgo(): check also for sysconfig PGO_PROF_USE_FLAG (if available) in compiler flags.* Move some SkipTest checks to test_gdb/__init__.py.* Elaborate why gdb cannot be tested on Windows: gdb doesn't support PDB debug symbol files.
Member
encukou commentedOct 3, 2023
Well, try to reenable would be better? |
MemberAuthor
vstinner commentedOct 3, 2023
vstinner added a commit to vstinner/cpython that referenced this pull requestOct 4, 2023
* Split test_pycfunction.py: add test_cfunction_full.py. Split the function into the following 6 functions. In verbose mode, these "pycfunction" tests now log each tested call. * test_pycfunction_noargs() * test_pycfunction_o() * test_pycfunction_varargs() * test_pycfunction_varargs_keywords() * test_pycfunction_fastcall() * test_pycfunction_fastcall_keywords()* Move get_gdb_repr() to PrettyPrintTests.* Replace DebuggerTests.get_sample_script() with SAMPLE_SCRIPT.* Rename checkout_hook_path to CHECKOUT_HOOK_PATH.* Rename gdb_version to GDB_VERSION_TEXT.* Replace (gdb_major_version, gdb_minor_version) with GDB_VERSION.* run_gdb() uses "backslashreplace" error handler instead of "replace".* Add check_gdb() function to util.py.* Enhance support.check_cflags_pgo(): check also for sysconfig PGO_PROF_USE_FLAG (if available) in compiler flags.* Move some SkipTest checks to test_gdb/__init__.py.* Elaborate why gdb cannot be tested on Windows: gdb doesn't support PDB debug symbol files.(cherry picked from commit757cbd4)
GH-110351 is a backport of this pull request to the3.12 branch. |
vstinner added a commit that referenced this pull requestOct 4, 2023
*gh-109972: Enhance test_gdb (#110026)* Split test_pycfunction.py: add test_cfunction_full.py. Split the function into the following 6 functions. In verbose mode, these "pycfunction" tests now log each tested call. * test_pycfunction_noargs() * test_pycfunction_o() * test_pycfunction_varargs() * test_pycfunction_varargs_keywords() * test_pycfunction_fastcall() * test_pycfunction_fastcall_keywords()* Move get_gdb_repr() to PrettyPrintTests.* Replace DebuggerTests.get_sample_script() with SAMPLE_SCRIPT.* Rename checkout_hook_path to CHECKOUT_HOOK_PATH.* Rename gdb_version to GDB_VERSION_TEXT.* Replace (gdb_major_version, gdb_minor_version) with GDB_VERSION.* run_gdb() uses "backslashreplace" error handler instead of "replace".* Add check_gdb() function to util.py.* Enhance support.check_cflags_pgo(): check also for sysconfig PGO_PROF_USE_FLAG (if available) in compiler flags.* Move some SkipTest checks to test_gdb/__init__.py.* Elaborate why gdb cannot be tested on Windows: gdb doesn't support PDB debug symbol files.(cherry picked from commit757cbd4)*gh-104736: Fix test_gdb tests on ppc64le with clang (#109360)Fix test_gdb on Python built with LLVM clang 16 on Linux ppc64le (ex:Fedora 38). Search patterns in gdb "bt" command output to detectwhen gdb fails to retrieve the traceback. For example, skip a test if"Backtrace stopped: frame did not save the PC" is found.(cherry picked from commit44d9a71)*gh-110166: Fix gdb CFunctionFullTests on ppc64le clang build (#110331)CFunctionFullTests now also runs "bt" command before "py-bt-full",similar to CFunctionTests which also runs "bt" command before"py-bt". So test_gdb can skip the test if patterns like "?? ()" arefound in the gdb output.(cherry picked from commit1de9406)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 4, 2023
…110351)*pythongh-109972: Enhance test_gdb (pythonGH-110026)* Split test_pycfunction.py: add test_cfunction_full.py. Split the function into the following 6 functions. In verbose mode, these "pycfunction" tests now log each tested call. * test_pycfunction_noargs() * test_pycfunction_o() * test_pycfunction_varargs() * test_pycfunction_varargs_keywords() * test_pycfunction_fastcall() * test_pycfunction_fastcall_keywords()* Move get_gdb_repr() to PrettyPrintTests.* Replace DebuggerTests.get_sample_script() with SAMPLE_SCRIPT.* Rename checkout_hook_path to CHECKOUT_HOOK_PATH.* Rename gdb_version to GDB_VERSION_TEXT.* Replace (gdb_major_version, gdb_minor_version) with GDB_VERSION.* run_gdb() uses "backslashreplace" error handler instead of "replace".* Add check_gdb() function to util.py.* Enhance support.check_cflags_pgo(): check also for sysconfig PGO_PROF_USE_FLAG (if available) in compiler flags.* Move some SkipTest checks to test_gdb/__init__.py.* Elaborate why gdb cannot be tested on Windows: gdb doesn't support PDB debug symbol files.(cherry picked from commit757cbd4)*pythongh-104736: Fix test_gdb tests on ppc64le with clang (pythonGH-109360)Fix test_gdb on Python built with LLVM clang 16 on Linux ppc64le (ex:Fedora 38). Search patterns in gdb "bt" command output to detectwhen gdb fails to retrieve the traceback. For example, skip a test if"Backtrace stopped: frame did not save the PC" is found.(cherry picked from commit44d9a71)*pythongh-110166: Fix gdb CFunctionFullTests on ppc64le clang build (pythonGH-110331)CFunctionFullTests now also runs "bt" command before "py-bt-full",similar to CFunctionTests which also runs "bt" command before"py-bt". So test_gdb can skip the test if patterns like "?? ()" arefound in the gdb output.(cherry picked from commitbbce8bd)Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit1de9406)
vstinner added a commit that referenced this pull requestOct 4, 2023
…10354)[3.12]gh-109972: Enhance test_gdb (GH-110026) (GH-110351)*gh-109972: Enhance test_gdb (GH-110026)* Split test_pycfunction.py: add test_cfunction_full.py. Split the function into the following 6 functions. In verbose mode, these "pycfunction" tests now log each tested call. * test_pycfunction_noargs() * test_pycfunction_o() * test_pycfunction_varargs() * test_pycfunction_varargs_keywords() * test_pycfunction_fastcall() * test_pycfunction_fastcall_keywords()* Move get_gdb_repr() to PrettyPrintTests.* Replace DebuggerTests.get_sample_script() with SAMPLE_SCRIPT.* Rename checkout_hook_path to CHECKOUT_HOOK_PATH.* Rename gdb_version to GDB_VERSION_TEXT.* Replace (gdb_major_version, gdb_minor_version) with GDB_VERSION.* run_gdb() uses "backslashreplace" error handler instead of "replace".* Add check_gdb() function to util.py.* Enhance support.check_cflags_pgo(): check also for sysconfig PGO_PROF_USE_FLAG (if available) in compiler flags.* Move some SkipTest checks to test_gdb/__init__.py.* Elaborate why gdb cannot be tested on Windows: gdb doesn't support PDB debug symbol files.(cherry picked from commit757cbd4)*gh-104736: Fix test_gdb tests on ppc64le with clang (GH-109360)Fix test_gdb on Python built with LLVM clang 16 on Linux ppc64le (ex:Fedora 38). Search patterns in gdb "bt" command output to detectwhen gdb fails to retrieve the traceback. For example, skip a test if"Backtrace stopped: frame did not save the PC" is found.(cherry picked from commit44d9a71)*gh-110166: Fix gdb CFunctionFullTests on ppc64le clang build (GH-110331)CFunctionFullTests now also runs "bt" command before "py-bt-full",similar to CFunctionTests which also runs "bt" command before"py-bt". So test_gdb can skip the test if patterns like "?? ()" arefound in the gdb output.(cherry picked from commitbbce8bd)Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit1de9406)Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
* Split test_pycfunction.py: add test_cfunction_full.py. Split the function into the following 6 functions. In verbose mode, these "pycfunction" tests now log each tested call. * test_pycfunction_noargs() * test_pycfunction_o() * test_pycfunction_varargs() * test_pycfunction_varargs_keywords() * test_pycfunction_fastcall() * test_pycfunction_fastcall_keywords()* Move get_gdb_repr() to PrettyPrintTests.* Replace DebuggerTests.get_sample_script() with SAMPLE_SCRIPT.* Rename checkout_hook_path to CHECKOUT_HOOK_PATH.* Rename gdb_version to GDB_VERSION_TEXT.* Replace (gdb_major_version, gdb_minor_version) with GDB_VERSION.* run_gdb() uses "backslashreplace" error handler instead of "replace".* Add check_gdb() function to util.py.* Enhance support.check_cflags_pgo(): check also for sysconfig PGO_PROF_USE_FLAG (if available) in compiler flags.* Move some SkipTest checks to test_gdb/__init__.py.* Elaborate why gdb cannot be tested on Windows: gdb doesn't support PDB debug symbol files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Split PyBtTests.test_pycfunction() into 2 files, test_cfunction and test_cfunction_full, and 6 functions:
In verbose mode, these "pycfunction" tests now log each tested call.
Move get_gdb_repr() to PrettyPrintTests.
Replace DebuggerTests.get_sample_script() with SAMPLE_SCRIPT.
Rename checkout_hook_path to CHECKOUT_HOOK_PATH.
Rename gdb_version to GDB_VERSION_TEXT.
Replace (gdb_major_version, gdb_minor_version) with GDB_VERSION.
run_gdb() uses "backslashreplace" error handler.
Add check_gdb() function to util.py.
Enhance support.check_cflags_pgo(): check also for sysconfig PGO_PROF_USE_FLAG (if available) in compiler flags.