Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-109594: Fix concurrent.futures test_timeout()#110018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fix test_timeout() of test_concurrent_futures.test_wait. Remove thefuture which may or may not complete depending if it takes longerthan the timeout ot not. Keep the second future which does notcomplete before wait(). Make also the test faster: 0.5 second insteadof 6 seconds, so remove @support.requires_resource('walltime')decorator.@serhiy-storchaka: One less cc@pitrou |
I stress-tested test_timeout() on Linux with the following command. I interrupted it after 5 minutes and 958 successful runs. |
Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 28, 2023
Fix test_timeout() of test_concurrent_futures.test_wait. Remove thefuture which may or may not complete depending if it takes longerthan the timeout ot not. Keep the second future which does notcomplete before wait(). Make also the test faster: 0.5 second insteadof 6 seconds, so remove @support.requires_resource('walltime')decorator.(cherry picked from commit9be283e)Co-authored-by: Victor Stinner <vstinner@python.org>miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 28, 2023
Fix test_timeout() of test_concurrent_futures.test_wait. Remove thefuture which may or may not complete depending if it takes longerthan the timeout ot not. Keep the second future which does notcomplete before wait(). Make also the test faster: 0.5 second insteadof 6 seconds, so remove @support.requires_resource('walltime')decorator.(cherry picked from commit9be283e)Co-authored-by: Victor Stinner <vstinner@python.org>GH-110021 is a backport of this pull request to the3.12 branch. |
GH-110022 is a backport of this pull request to the3.11 branch. |
vstinner added a commit that referenced this pull requestSep 28, 2023
…110022)gh-109594: Fix concurrent.futures test_timeout() (GH-110018)Fix test_timeout() of test_concurrent_futures.test_wait. Remove thefuture which may or may not complete depending if it takes longerthan the timeout ot not. Keep the second future which does notcomplete before wait(). Make also the test faster: 0.5 second insteadof 6 seconds, so remove @support.requires_resource('walltime')decorator.(cherry picked from commit9be283e)Co-authored-by: Victor Stinner <vstinner@python.org>
csm10495 pushed a commit to csm10495/cpython that referenced this pull requestSep 29, 2023
Fix test_timeout() of test_concurrent_futures.test_wait. Remove thefuture which may or may not complete depending if it takes longerthan the timeout ot not. Keep the second future which does notcomplete before wait(). Make also the test faster: 0.5 second insteadof 6 seconds, so remove @support.requires_resource('walltime')decorator.Yhg1s pushed a commit that referenced this pull requestOct 2, 2023
…110021)gh-109594: Fix concurrent.futures test_timeout() (GH-110018)Fix test_timeout() of test_concurrent_futures.test_wait. Remove thefuture which may or may not complete depending if it takes longerthan the timeout ot not. Keep the second future which does notcomplete before wait(). Make also the test faster: 0.5 second insteadof 6 seconds, so remove @support.requires_resource('walltime')decorator.(cherry picked from commit9be283e)Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Fix test_timeout() of test_concurrent_futures.test_wait. Remove thefuture which may or may not complete depending if it takes longerthan the timeout ot not. Keep the second future which does notcomplete before wait(). Make also the test faster: 0.5 second insteadof 6 seconds, so remove @support.requires_resource('walltime')decorator.Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fix test_timeout() of test_concurrent_futures.test_wait. Remove the future which may or may not complete depending if it takes longer than the timeout ot not. Keep the second future which does not complete before wait(). Make also the test faster: 0.5 second instead of 6 seconds, so remove @support.requires_resource('walltime') decorator.