Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100228: Document the os.fork threads DeprecationWarning.#109767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 9 commits intopython:mainfromgpshead:docs/fork_threads_warning
Sep 23, 2023

Conversation

gpshead
Copy link
Member

@gpsheadgpshead commentedSep 23, 2023•
edited by bedevere-appbot
Loading

@gpsheadgpshead added docsDocumentation in the Doc dir skip news needs backport to 3.12only security fixes labelsSep 23, 2023
@gpsheadgpshead changed the titleDocument the os.fork threads DeprecationWarning.gh-100228: Document the os.fork threads DeprecationWarning.Sep 23, 2023
@gpsheadgpshead marked this pull request as ready for reviewSeptember 23, 2023 00:20
gpsheadand others added6 commitsSeptember 22, 2023 21:09
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, couple of suggestions.

gpshead reacted with hooray emoji
gpsheadand others added2 commitsSeptember 22, 2023 21:53
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

A

gpshead reacted with heart emoji
@gpsheadgpsheadenabled auto-merge (squash)September 23, 2023 05:03
@gpsheadgpshead merged commit5e7ea95 intopython:mainSep 23, 2023
@miss-islington
Copy link
Contributor

Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@gpsheadgpshead deleted the docs/fork_threads_warning branchSeptember 23, 2023 05:04
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 23, 2023
…thonGH-109767)Document the `os.fork` posix threads detected `DeprecationWarning` in 3.12 What's New, os, multiprocessing, and concurrent.futures docs.Many reviews and doc cleanup edits by Adam & Hugo. 🥳(cherry picked from commit5e7ea95)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-109773 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelSep 23, 2023
Copy link
Member

@malemburgmalemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for adding these clarifications and warnings.

Apart from the change in the "What's new" I think this is good to go.

We added the warning to to raise awareness as issues encounted by code doing
this are becoming more frequent. See the:func:`os.fork` documentation for
more details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would copy the paragraph from the os.fork() docs here as well, to make it easier for people to find the reasoning behind this:

See `this discussion on fork being incompatible with threads<https://discuss.python.org/t/33555>`_for technical details of why we're surfacing this longstandingplatform compatibility problem to developers.

gpshead reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, I included that (edited) over in the 3.12 backport#109773. I'll make the same edit inmain after that is merged.

gpshead added a commit to miss-islington/cpython that referenced this pull requestSep 23, 2023
Include the link to the discussion in the what's new text per @malemberg's comment on.python#109767(i'll follow up with a PR to main to include this edit there as well)
Yhg1s pushed a commit that referenced this pull requestSep 24, 2023
…H-109767) (#109773)*gh-100228: Document the os.fork threads DeprecationWarning. (GH-109767)Document the `os.fork` posix threads detected `DeprecationWarning` in 3.12 What's New, os, multiprocessing, and concurrent.futures docs.Many reviews and doc cleanup edits by Adam & Hugo. 🥳(cherry picked from commit5e7ea95)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>* link to the discussion thread from whatsnewInclude the link to the discussion in the what's new text per @malemberg's comment on.#109767(i'll follow up with a PR to main to include this edit there as well)---------Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
gpshead added a commit that referenced this pull requestSep 24, 2023
A post main merge edit to the text was added in the 3.12 backport PR.e38d710This includes that in main.  It's a minor edit over#109767 to resolve the comment there.
github-actionsbot pushed a commit to m-aciek/python-docs-weblate that referenced this pull requestSep 24, 2023
…H-109767) (#109773)* gh-100228: Document the os.fork threads DeprecationWarning. (GH-109767)Document the `os.fork` posix threads detected `DeprecationWarning` in 3.12 What's New, os, multiprocessing, and concurrent.futures docs.Many reviews and doc cleanup edits by Adam & Hugo. 🥳(cherry picked from commit 5e7ea95d9d5c3b80a67ffbeebd76ce4fc327dd8e)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>* link to the discussion thread from whatsnewInclude the link to the discussion in the what's new text per @malemberg's comment on.python/cpython#109767(i'll follow up with a PR to main to include this edit there as well)---------Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>CPython-sync-commit: 62df559448362f9a4291661d64aee30474dec025
csm10495 pushed a commit to csm10495/cpython that referenced this pull requestSep 28, 2023
…thon#109767)Document the `os.fork` posix threads detected `DeprecationWarning` in 3.12 What's New, os, multiprocessing, and concurrent.futures docs.Many reviews and doc cleanup edits by Adam & Hugo. 🥳 Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
csm10495 pushed a commit to csm10495/cpython that referenced this pull requestSep 28, 2023
…09807)A post main merge edit to the text was added in the 3.12 backport PR.python@e38d710This includes that in main.  It's a minor edit overpython#109767 to resolve the comment there.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…thon#109767)Document the `os.fork` posix threads detected `DeprecationWarning` in 3.12 What's New, os, multiprocessing, and concurrent.futures docs.Many reviews and doc cleanup edits by Adam & Hugo. 🥳 Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…09807)A post main merge edit to the text was added in the 3.12 backport PR.python@e38d710This includes that in main.  It's a minor edit overpython#109767 to resolve the comment there.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@malemburgmalemburgmalemburg left review comments

@hugovkhugovkhugovk approved these changes

@AA-TurnerAA-TurnerAA-Turner approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@gpshead@miss-islington@hugovk@malemburg@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp