Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-109627: duplicated smalll exit blocks need to be assigned jump target labels#109630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 2 commits intopython:mainfromiritkatriel:label-bug
Sep 20, 2023

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedSep 20, 2023•
edited by bedevere-appbot
Loading

Fixes#109627.

In order to ensure that function exits have a line number, the compiler duplicates small exit blocks which (1) do not have a line number in any instruction and (2) have more than one predecessor. Since these blocks are jump targets (at least one predecessor reaches this block via a jump or exception), they need to have labels assigned to them. This was missing, and is added in this PR.

@iritkatrieliritkatriel added type-bugAn unexpected behavior, bug, or error needs backport to 3.12only security fixes interpreter-core(Objects, Python, Grammar, and Parser dirs) labelsSep 20, 2023
@iritkatrieliritkatrielenabled auto-merge (squash)September 20, 2023 22:51
@iritkatrieliritkatriel merged commit9ccf054 intopython:mainSep 20, 2023
@miss-islington
Copy link
Contributor

Thanks@iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@iritkatriel, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 9ccf0545efd5bc5af5aa51774030c471d49a972b 3.12

iritkatriel added a commit to iritkatriel/cpython that referenced this pull requestSep 20, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this pull requestSep 20, 2023
@bedevere-app
Copy link

GH-109632 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelSep 20, 2023
@bedevere-app
Copy link

GH-109632 is a backport of this pull request to the3.12 branch.

Yhg1s pushed a commit that referenced this pull requestSep 22, 2023
…mp target labels (#109630) (#109632)gh-109627: duplicated smalll exit blocks need to be assigned jump target labels (#109630)(cherry picked from commit9ccf054)
csm10495 pushed a commit to csm10495/cpython that referenced this pull requestSep 28, 2023
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@carljmcarljmcarljm approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstra

Assignees

@iritkatrieliritkatriel

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)release-blockertype-bugAn unexpected behavior, bug, or error

Projects

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

basicblock_addop Assertion

3 participants

@iritkatriel@miss-islington@carljm
[8]ページ先頭
©2009-2025 Movatter.jp