Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode#109423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:fips_hmac_sha1
Sep 14, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedSep 14, 2023•
edited by bedevere-appbot
Loading

Use a longer key: FIPS mode requires at least of at least 112 bits. The previous key was only 32 bits.

Use a longer key: FIPS mode requires at least of at least 112 bits.The previous key was only 32 bits.
@vstinner
Copy link
MemberAuthor

I tested manually that the change fix test_socket on the affected RHEL8 FIPS buildbot:

[vstinner@python-builder-rhel8-fips cpython]$ cat /proc/sys/crypto/fips_enabled1[vstinner@python-builder-rhel8-fips cpython]$ ./python -m test test_socket -v -m test_hmac_sha1== CPython 3.13.0a0 (heads/main:d7dc3d9, Sep 14 2023, 16:42:17) [GCC 8.5.0 20210514 (Red Hat 8.5.0-18)]== Linux-4.18.0-477.21.1.el8_8.x86_64-x86_64-with-glibc2.28 little-endian(...)Total tests: run=1 (filtered)Total test files: run=1/1 (filtered)Result: SUCCESS

@vstinner
Copy link
MemberAuthor

By the way, this buildbot is running:

[vstinner@python-builder-rhel8-fips cpython]$ uname -r4.18.0-477.21.1.el8_8.x86_64[vstinner@python-builder-rhel8-fips cpython]$ cat /etc/redhat-release Red Hat Enterprise Linux release 8.8 (Ootpa)

@vstinnervstinner added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsSep 14, 2023
@vstinnervstinnerenabled auto-merge (squash)September 14, 2023 21:01
@vstinnervstinner merged commite091b9f intopython:mainSep 14, 2023
@vstinnervstinner deleted the fips_hmac_sha1 branchSeptember 14, 2023 21:24
@miss-islington
Copy link
Contributor

Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 14, 2023
…nGH-109423)Use a longer key: FIPS mode requires at least of at least 112 bits.The previous key was only 32 bits.(cherry picked from commite091b9f)Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

GH-109426 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelSep 14, 2023
@bedevere-app
Copy link

GH-109427 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelSep 14, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 14, 2023
…nGH-109423)Use a longer key: FIPS mode requires at least of at least 112 bits.The previous key was only 32 bits.(cherry picked from commite091b9f)Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x RHEL7 LTO 3.x has failed when building commite091b9f.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/402/builds/5396) and take a look at the build logs.
  4. Check if the failure is related to this commit (e091b9f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/402/builds/5396

Failed tests:

  • test.test_asyncio.test_subprocess

Failed subtests:

  • test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_asyncio/test_subprocess.py", line788, intest_subprocess_consistent_callbacksself.loop.run_until_complete(main())  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/asyncio/base_events.py", line664, inrun_until_completereturn future.result()^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_asyncio/test_subprocess.py", line780, inmainself.assertEqual(events, [AssertionError:Lists differ: ['process_exited', ('pipe_data_received', 1, b'stdout')] != [('pipe_data_received', 1, b'stdout'), ('p[95 chars]ted']

Yhg1s pushed a commit that referenced this pull requestSep 14, 2023
…09423) (#109426)gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423)Use a longer key: FIPS mode requires at least of at least 112 bits.The previous key was only 32 bits.(cherry picked from commite091b9f)Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner
Copy link
MemberAuthor

The affected buildbot turned green (success):https://buildbot.python.org/all/#/builders/469/builds/6002 :-) It is the first time that it becomes green for a long time. It was failing for at least 3 weeks, but it's likely that it wasnever green.

vstinner added a commit that referenced this pull requestSep 14, 2023
…09423) (#109427)gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423)Use a longer key: FIPS mode requires at least of at least 112 bits.The previous key was only 32 bits.(cherry picked from commite091b9f)Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit to miss-islington/cpython that referenced this pull requestOct 8, 2024
…pythonGH-109423) (pythonGH-109427)pythongh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (pythonGH-109423)Use a longer key: FIPS mode requires at least of at least 112 bits.The previous key was only 32 bits.(cherry picked from commite091b9f)(cherry picked from commitf7bfac4)Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit to miss-islington/cpython that referenced this pull requestOct 8, 2024
…pythonGH-109423) (pythonGH-109427)pythongh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (pythonGH-109423)Use a longer key: FIPS mode requires at least of at least 112 bits.The previous key was only 32 bits.(cherry picked from commite091b9f)(cherry picked from commitf7bfac4)Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

GH-125106 is a backport of this pull request to the3.10 branch.

@bedevere-app
Copy link

GH-125107 is a backport of this pull request to the3.9 branch.

pablogsal pushed a commit that referenced this pull requestOct 22, 2024
…09423) (#125106)[3.11]gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423) (GH-109427)gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423)Use a longer key: FIPS mode requires at least of at least 112 bits.The previous key was only 32 bits.(cherry picked from commite091b9f)(cherry picked from commitf7bfac4)Co-authored-by: Victor Stinner <vstinner@python.org>Co-authored-by: Petr Viktorin <encukou@gmail.com>
ambv pushed a commit that referenced this pull requestNov 4, 2024
…9423) (GH-125107)Use a longer key: FIPS mode requires at least of at least 112 bits.The previous key was only 32 bits.(cherry picked from commite091b9f)(cherry picked from commitf7bfac4)Co-authored-by: Victor Stinner <vstinner@python.org>Co-authored-by: Petr Viktorin <encukou@gmail.com>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestApr 9, 2025
…ythonGH-109423) (pythonGH-125107)Use a longer key: FIPS mode requires at least of at least 112 bits.The previous key was only 32 bits.(cherry picked from commite091b9f)(cherry picked from commitf7bfac4)Co-authored-by: Victor Stinner <vstinner@python.org>Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
testsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp