Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix sphinx warnings inturtle.rst#109394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
terryjreedy merged 1 commit intopython:mainfromsobolevn:issue-101100-turtle
Sep 14, 2023

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedSep 14, 2023•
edited by github-actionsbot
Loading

It was:

/Users/sobolev/Desktop/cpython/Doc/library/turtle.rst:2318: WARNING: py:class reference target not found: tkinter.Canvas/Users/sobolev/Desktop/cpython/Doc/library/turtle.rst:2333: WARNING: py:class reference target not found: tkinter.Canvas/Users/sobolev/Desktop/cpython/Doc/library/turtle.rst:2415: WARNING: py:class reference target not found: tkinter.Canvas/Users/sobolev/Desktop/cpython/Doc/library/turtle.rst:2421: WARNING: py:class reference target not found: tkinter.Canvas

But, sincetkinter.Canvas is not documented intkinter, we cannot reference it.

📚 Documentation preview 📚:https://cpython-previews--109394.org.readthedocs.build/

Copy link
Member

@AlexWaygoodAlexWaygood left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perhaps a better fix might be just to documenttkinter.Canvas in thetkinter docs? I don't know much about tkinter, though,so maybe there's a reason why it's not documented currently :)

Copy link
Member

@terryjreedyterryjreedy left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks right given the current state of tkinter docs. The tkinter widget docs were referred to external sources. Only the ttk widget are documented (and with a few error as I remember). This should be fixed, and there may be an issue, but it will be a big project to do right.

@terryjreedyterryjreedy added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsSep 14, 2023
@terryjreedyterryjreedy merged commit21e80f4 intopython:mainSep 14, 2023
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 14, 2023
(cherry picked from commit21e80f4)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

GH-109416 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelSep 14, 2023
@bedevere-app
Copy link

GH-109417 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelSep 14, 2023
@terryjreedy
Copy link
Member

If and when the tk widgetsare documented, I (we) should hopefully remember to search .rst files for '!tkinter' to see where the '1' can/should be removed.

AlexWaygood reacted with thumbs up emoji

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 14, 2023
(cherry picked from commit21e80f4)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
terryjreedy pushed a commit that referenced this pull requestSep 14, 2023
…09417)(cherry picked from commit21e80f4)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Yhg1s pushed a commit that referenced this pull requestSep 14, 2023
…09416)gh-101100: Fix sphinx warnings in `turtle.rst` (GH-109394)(cherry picked from commit21e80f4)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

@terryjreedyterryjreedyterryjreedy approved these changes

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@sobolevn@miss-islington@terryjreedy@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp