Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-105658: fix excess trace events for except block ending with a conditional block#109384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 4 commits intopython:mainfromiritkatriel:lineno-try
Sep 14, 2023

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedSep 13, 2023
edited
Loading

This will remove the event with the wrong line number. It will still work because RERAISE doesn't need to have a line number attached. In exception_unwind, the instruction pointer on the frame is used to determine which exception handler should be invoked. The location of the reraise doesn't show up in the traceback.

Fixes#105658.

@iritkatrieliritkatriel added type-bugAn unexpected behavior, bug, or error needs backport to 3.12only security fixes labelsSep 13, 2023
@iritkatrieliritkatriel changed the titlegh-109156: fix excess trace events for except block ending with a con…gh-105658: fix excess trace events for except block ending with a con…Sep 13, 2023
Copy link
Member

@carljmcarljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't see a test here that reflects the case in the filed bug, where the line number actually jumps back to a previous line in a conditional. I believe that this change would fix that, but would it make sense to add an explicit test for it?

iritkatriel reacted with thumbs up emoji
iritkatrieland others added2 commitsSeptember 14, 2023 15:33
Co-authored-by: Carl Meyer <carl@oddbird.net>
(3,'line'),
(3,'exception'),
(5,'line'),
(6,'line'),
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

On main we have here another
(5, 'line'),

carljm reacted with thumbs up emoji
@iritkatrieliritkatriel changed the titlegh-105658: fix excess trace events for except block ending with a con…gh-105658: fix excess trace events for except block ending with a conditional blockSep 14, 2023
@iritkatrieliritkatriel merged commit4a54074 intopython:mainSep 14, 2023
@miss-islington
Copy link
Contributor

Thanks@iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@iritkatriel, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 4a54074a0f5579d417445ec28427cd0ed5aa01f4 3.12

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 RHEL7 3.x has failed when building commit4a54074.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/15/builds/5670) and take a look at the build logs.
  4. Check if the failure is related to this commit (4a54074) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/15/builds/5670

Failed tests:

  • test.test_asyncio.test_subprocess

Failed subtests:

  • test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_asyncio/test_subprocess.py", line788, intest_subprocess_consistent_callbacksself.loop.run_until_complete(main())  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/asyncio/base_events.py", line664, inrun_until_completereturn future.result()^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_asyncio/test_subprocess.py", line780, inmainself.assertEqual(events, [AssertionError:Lists differ: [('pi[29 chars]t'), 'pipe_connection_lost', ('pipe_data_recei[57 chars]ted'] != [('pi[29 chars]t'), ('pipe_data_received', 2, b'stderr'), 'pi[57 chars]ted']

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x RHEL7 3.x has failed when building commit4a54074.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/179/builds/5477) and take a look at the build logs.
  4. Check if the failure is related to this commit (4a54074) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/179/builds/5477

Failed tests:

  • test.test_asyncio.test_subprocess
  • test_eintr

Failed subtests:

  • test_all - test.test_eintr.EINTRTests.test_all
  • test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks
  • test_flock -main.FNTLEINTRTest.test_flock

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_eintr.py", line17, intest_all    script_helper.run_test_script(script)  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/support/script_helper.py", line300, inrun_test_scriptraiseAssertionError(f"{name} failed")AssertionError:script _test_eintr.py failedTraceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_asyncio/test_subprocess.py", line788, intest_subprocess_consistent_callbacksself.loop.run_until_complete(main())  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/asyncio/base_events.py", line664, inrun_until_completereturn future.result()^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_asyncio/test_subprocess.py", line780, inmainself.assertEqual(events, [AssertionError:Lists differ: [('pi[29 chars]t'), 'pipe_connection_lost', ('pipe_data_recei[57 chars]ted'] != [('pi[29 chars]t'), ('pipe_data_received', 2, b'stderr'), 'pi[57 chars]ted']Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/_test_eintr.py", line526, intest_flockself._lock(fcntl.flock,"flock")  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/_test_eintr.py", line515, in_lockself.assertGreaterEqual(dt,self.sleep_time)AssertionError:0.1990837489720434 not greater than or equal to 0.2

iritkatriel added a commit to iritkatriel/cpython that referenced this pull requestSep 14, 2023
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM64 macOS 3.x has failed when building commit4a54074.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/5644) and take a look at the build logs.
  4. Check if the failure is related to this commit (4a54074) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/5644

Failed tests:

  • test_signal

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 24, done.remote:Counting objects:   4% (1/24)remote:Counting objects:   8% (2/24)remote:Counting objects:  12% (3/24)remote:Counting objects:  16% (4/24)remote:Counting objects:  20% (5/24)remote:Counting objects:  25% (6/24)remote:Counting objects:  29% (7/24)remote:Counting objects:  33% (8/24)remote:Counting objects:  37% (9/24)remote:Counting objects:  41% (10/24)remote:Counting objects:  45% (11/24)remote:Counting objects:  50% (12/24)remote:Counting objects:  54% (13/24)remote:Counting objects:  58% (14/24)remote:Counting objects:  62% (15/24)remote:Counting objects:  66% (16/24)remote:Counting objects:  70% (17/24)remote:Counting objects:  75% (18/24)remote:Counting objects:  79% (19/24)remote:Counting objects:  83% (20/24)remote:Counting objects:  87% (21/24)remote:Counting objects:  91% (22/24)remote:Counting objects:  95% (23/24)remote:Counting objects: 100% (24/24)remote:Counting objects: 100% (24/24), done.remote:Compressing objects:   7% (1/13)remote:Compressing objects:  15% (2/13)remote:Compressing objects:  23% (3/13)remote:Compressing objects:  30% (4/13)remote:Compressing objects:  38% (5/13)remote:Compressing objects:  46% (6/13)remote:Compressing objects:  53% (7/13)remote:Compressing objects:  61% (8/13)remote:Compressing objects:  69% (9/13)remote:Compressing objects:  76% (10/13)remote:Compressing objects:  84% (11/13)remote:Compressing objects:  92% (12/13)remote:Compressing objects: 100% (13/13)remote:Compressing objects: 100% (13/13), done.remote:Total 13 (delta 11), reused 0 (delta 0), pack-reused 0From https://github.com/python/cpython * branch                  main       -> FETCH_HEADNote:switching to '4a54074a0f5579d417445ec28427cd0ed5aa01f4'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 4a54074a0f gh-105658: fix excess trace events for except block ending with a conditional block (#109384)Switched to and reset branch 'main'./Modules/readline.c:1256:21: warning: incompatible function pointer types assigning to 'Function *' (aka 'int (*)(const char *, int)') from 'int (void)' [-Wincompatible-function-pointer-types]    rl_startup_hook= on_startup_hook;^~~~~~~~~~~~~~~~./Modules/readline.c:1258:23: warning: incompatible function pointer types assigning to 'Function *' (aka 'int (*)(const char *, int)') from 'int (void)' [-Wincompatible-function-pointer-types]    rl_pre_input_hook= on_pre_input_hook;^~~~~~~~~~~~~~~~~~2 warnings generated.In file included from ./Modules/_tkinter.c:52:In file included from /opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/tk.h:99:/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:131:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]int (*free_private)();/* called to free private storage*/^                            void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:334:33: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]        struct _XImage*(*create_image)();^                                        void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:453:23: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]        XID (*resource_alloc)();/* allocator function*/^                              void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:471:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]int (*synchandler)();/* Synchronization handler*/^                           void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:496:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]        Bool (*event_vec[128])();/* vectorfor wire to event*/^                               void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:497:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]        Status (*wire_vec[128])();/* vectorfor event to wire*/^                                void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:509:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]        Bool (**error_vec)();/* vectorfor wire to error*/^                           void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:522:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]int (*savedsynchandler)();/* user synchandler when Xlib usurps*/^                                void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:1053:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]typedef void (*XIMProc)();^                        voidIn file included from ./Modules/tkappinit.c:17:In file included from /opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/tk.h:99:/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:131:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]int (*free_private)();/* called to free private storage*/^                            void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:334:33: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]        struct _XImage*(*create_image)();^                                        void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:453:23: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]        XID (*resource_alloc)();/* allocator function*/^                              void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:471:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]int (*synchandler)();/* Synchronization handler*/^                           void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:496:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]        Bool (*event_vec[128])();/* vectorfor wire to event*/^                               void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:497:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]        Status (*wire_vec[128])();/* vectorfor event to wire*/^                                void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:509:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]        Bool (**error_vec)();/* vectorfor wire to error*/^                           void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:522:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]int (*savedsynchandler)();/* user synchandler when Xlib usurps*/^                                void/opt/homebrew/Cellar/tcl-tk/8.6.13_4/include/tcl-tk/X11/Xlib.h:1053:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]typedef void (*XIMProc)();^                        void9 warnings generated.9 warnings generated../Modules/_testcapimodule.c:225:18: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]assert(k!=UNINITIALIZED_PTR);^~~~~~~~~~~~~~~~~~/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'    (__builtin_expect(!(e),0)? __assert_rtn(__func__,__ASSERT_FILE_NAME,__LINE__,#e) : (void)0)^./Modules/_testcapimodule.c:226:18: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]assert(v!=UNINITIALIZED_PTR);^~~~~~~~~~~~~~~~~~/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'    (__builtin_expect(!(e),0)? __assert_rtn(__func__,__ASSERT_FILE_NAME,__LINE__,#e) : (void)0)^./Modules/_testcapimodule.c:238:14: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]assert(k==UNINITIALIZED_PTR);^~~~~~~~~~~~~~~~~~/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'    (__builtin_expect(!(e),0)? __assert_rtn(__func__,__ASSERT_FILE_NAME,__LINE__,#e) : (void)0)^./Modules/_testcapimodule.c:239:14: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]assert(v==UNINITIALIZED_PTR);^~~~~~~~~~~~~~~~~~/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'    (__builtin_expect(!(e),0)? __assert_rtn(__func__,__ASSERT_FILE_NAME,__LINE__,#e) : (void)0)^./Modules/_testcapi/dict.c:289:16: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]assert(key==UNINITIALIZED_PTR);^~~~~~~~~~~~~~~~~~/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'    (__builtin_expect(!(e),0)? __assert_rtn(__func__,__ASSERT_FILE_NAME,__LINE__,#e) : (void)0)^./Modules/_testcapi/dict.c:290:18: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]assert(value==UNINITIALIZED_PTR);^~~~~~~~~~~~~~~~~~/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'    (__builtin_expect(!(e),0)? __assert_rtn(__func__,__ASSERT_FILE_NAME,__LINE__,#e) : (void)0)^4 warnings generated.2 warnings generated../Modules/_testcapi/exceptions.c:129:17: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]assert(type!=UNINITIALIZED_PTR);^~~~~~~~~~~~~~~~~~/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'    (__builtin_expect(!(e),0)? __assert_rtn(__func__,__ASSERT_FILE_NAME,__LINE__,#e) : (void)0)^./Modules/_testcapi/exceptions.c:130:18: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]assert(value!=UNINITIALIZED_PTR);^~~~~~~~~~~~~~~~~~/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'    (__builtin_expect(!(e),0)? __assert_rtn(__func__,__ASSERT_FILE_NAME,__LINE__,#e) : (void)0)^./Modules/_testcapi/exceptions.c:131:15: warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]assert(tb!=UNINITIALIZED_PTR);^~~~~~~~~~~~~~~~~~/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'    (__builtin_expect(!(e),0)? __assert_rtn(__func__,__ASSERT_FILE_NAME,__LINE__,#e) : (void)0)^3 warnings generated.Kill <WorkerThread #1 running test=test_faulthandler pid=8578 time=4.6 sec> process groupKill <WorkerThread #2 running test=test.test_asyncio.test_sslproto pid=8625 time=13 ms> process groupKill <WorkerThread #3 running test=test.test_multiprocessing_spawn.test_manager pid=8494 time=9.3 sec> process groupmake:*** [buildbottest] Error 5

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora 3.x has failed when building commit4a54074.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/223/builds/4472) and take a look at the build logs.
  4. Check if the failure is related to this commit (4a54074) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/223/builds/4472

Failed tests:

  • test_tools

Failed subtests:

  • test_freeze_simple_script - test.test_tools.test_freeze.TestFreeze.test_freeze_simple_script

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/Lib/test/test_tools/test_freeze.py", line28, intest_freeze_simple_script    outdir, scriptfile, python= helper.prepare(script, outdir)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/Tools/freeze/test/freeze.py", line146, inprepare    copy_source_tree(srcdir,SRCDIR)  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/Tools/freeze/test/freeze.py", line95, incopy_source_tree    shutil.copytree(oldroot, newroot,ignore=ignore_non_src)  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/Lib/shutil.py", line588, incopytreereturn _copytree(entries=entries,src=src,dst=dst,symlinks=symlinks,^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/Lib/shutil.py", line542, in_copytreeraise Error(errors)shutil.Error:[('/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/build/test_python_3767069æ/@test_3767069_tmpæ2', '/tmp/test_python_homi55ju/tmp0bv9x_jb/cpython/build/test_python_3767069æ/@test_3767069_tmpæ2', "[Errno 2] No such file or directory: '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/build/test_python_3767069æ/@test_3767069_tmpæ2'"), ('/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/build/test_python_3767369æ', '/tmp/test_python_homi55ju/tmp0bv9x_jb/cpython/build/test_python_3767369æ', "[Errno 2] No such file or directory: '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/build/test_python_3767369æ'"), ('/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/build/test_python_3767386æ', '/tmp/test_python_homi55ju/tmp0bv9x_jb/cpython/build/test_python_3767386æ', "[Errno 2] No such file or directory: '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/build/test_python_3767386æ'")]

@bedevere-app
Copy link

GH-109411 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelSep 14, 2023
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu Shared 3.x has failed when building commit4a54074.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/506/builds/5869) and take a look at the build logs.
  4. Check if the failure is related to this commit (4a54074) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/506/builds/5869

Failed tests:

  • test_shutil

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 24, done.remote:Counting objects:   4% (1/24)remote:Counting objects:   8% (2/24)remote:Counting objects:  12% (3/24)remote:Counting objects:  16% (4/24)remote:Counting objects:  20% (5/24)remote:Counting objects:  25% (6/24)remote:Counting objects:  29% (7/24)remote:Counting objects:  33% (8/24)remote:Counting objects:  37% (9/24)remote:Counting objects:  41% (10/24)remote:Counting objects:  45% (11/24)remote:Counting objects:  50% (12/24)remote:Counting objects:  54% (13/24)remote:Counting objects:  58% (14/24)remote:Counting objects:  62% (15/24)remote:Counting objects:  66% (16/24)remote:Counting objects:  70% (17/24)remote:Counting objects:  75% (18/24)remote:Counting objects:  79% (19/24)remote:Counting objects:  83% (20/24)remote:Counting objects:  87% (21/24)remote:Counting objects:  91% (22/24)remote:Counting objects:  95% (23/24)remote:Counting objects: 100% (24/24)remote:Counting objects: 100% (24/24), done.remote:Compressing objects:   7% (1/13)remote:Compressing objects:  15% (2/13)remote:Compressing objects:  23% (3/13)remote:Compressing objects:  30% (4/13)remote:Compressing objects:  38% (5/13)remote:Compressing objects:  46% (6/13)remote:Compressing objects:  53% (7/13)remote:Compressing objects:  61% (8/13)remote:Compressing objects:  69% (9/13)remote:Compressing objects:  76% (10/13)remote:Compressing objects:  84% (11/13)remote:Compressing objects:  92% (12/13)remote:Compressing objects: 100% (13/13)remote:Compressing objects: 100% (13/13), done.remote:Total 13 (delta 11), reused 0 (delta 0), pack-reused 0From https://github.com/python/cpython * branch                  main       -> FETCH_HEADNote:switching to '4a54074a0f5579d417445ec28427cd0ed5aa01f4'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 4a54074a0f gh-105658: fix excess trace events for except block ending with a conditional block (#109384)Switched to and reset branch 'main'configure:WARNING: pkg-config is missing. Some dependencies may not be detected correctly.Kill <WorkerThread #1 running test=test.test_multiprocessing_forkserver.test_processes pid=2801313 time=2 min 9 sec> process groupmake:*** [Makefile:2033: buildbottest] Error 5

Yhg1s pushed a commit that referenced this pull requestSep 14, 2023
…h a conditional block (#109384) (#109411)gh-105658: fix excess trace events for except block ending with a conditional block (#109384)(cherry picked from commit4a54074)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@carljmcarljmcarljm approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@brandtbucherbrandtbucherAwaiting requested review from brandtbucher

Assignees

@iritkatrieliritkatriel

Labels

type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3.12 tracing regression: a conditional in a finally block will revisit the condition before exiting the block.

4 participants

@iritkatriel@miss-islington@bedevere-bot@carljm

[8]ページ先頭

©2009-2025 Movatter.jp